Times are UTC Toggle Colours
00:01:11 *** Thedarkb1-T60 has quit IRC 00:01:36 *** Mahjong1 has quit IRC 00:27:50 *** HerzogDeXtEr has quit IRC 00:32:59 *** Samu has quit IRC 01:07:17 *** Flygon has joined #openttd 02:02:22 *** Pikka has quit IRC 02:55:44 *** Supercheese has quit IRC 03:15:41 *** haudrauf has quit IRC 03:16:39 *** haudrauf has joined #openttd 04:37:23 *** agentw4b has quit IRC 05:09:17 *** snail_UES_ has quit IRC 05:17:07 *** glx has quit IRC 05:42:03 *** synchris has joined #openttd 06:19:22 *** Arveen2 has joined #openttd 06:23:33 *** Arveen has quit IRC 06:40:40 *** andythenorth has joined #openttd 07:07:27 *** andythenorth has quit IRC 07:12:16 *** andythenorth has joined #openttd 07:38:13 *** andythenorth has quit IRC 07:49:52 *** andythenorth has joined #openttd 08:01:49 *** andythenorth has quit IRC 08:04:08 *** quiznilo has joined #openttd 08:18:00 *** andythenorth has joined #openttd 08:30:57 *** andythenorth has quit IRC 08:40:12 *** OtakuSenpai has joined #openttd 08:47:38 *** TheMask96 has quit IRC 08:51:51 *** TheMask96 has joined #openttd 09:15:42 *** HerzogDeXtEr has joined #openttd 09:45:51 *** OtakuSenpai has quit IRC 09:46:23 *** OtakuSenpai has joined #openttd 09:59:52 *** andythenorth has joined #openttd 11:01:12 *** mikegrb has joined #openttd 11:18:31 *** Thedarkb-T60 has joined #openttd 11:23:30 <Heiki> how should I go about fixing an error in the Finnish translation (STR_ORDER_CONDITIONAL_COMPARATOR_LESS_EQUALS is translated as “is greater than”)? 11:29:35 <LordAro> https://translator.openttd.org 11:31:49 *** Samu has joined #openttd 11:32:12 <Heiki> registered and logged in and tried that, but it only tells me “Access denied” when I try to do something 11:34:00 <LordAro> i imagine you've not been approved by the mysterious translation manager 11:35:17 <Heiki> should I just wait or does the mysterious translation manager want something from me? 11:36:44 <LordAro> mostly likely the former 11:37:09 <LordAro> it's likely no one's looked at the mailbox recently 11:38:31 <Heiki> and I only registered half an hour ago 11:44:21 <LordAro> well then 11:51:35 <Samu> Rubidium wrote: For some technical reasons we can't suspend squirrel while it is running a Valuate. 11:51:38 <Samu> :( 12:06:31 *** andythenorth has quit IRC 12:18:43 <Samu> @calc (5000 / (2048 * 2048)) * 4096 * 4096 12:18:43 <DorpsGek> Samu: 20000 12:21:01 <Samu> inb4 commit message failure 12:24:42 *** Thedarkb-T60 has quit IRC 12:25:08 *** Thedarkb-T60 has joined #openttd 12:58:00 *** snail_UES_ has joined #openttd 13:08:08 *** tokai has joined #openttd 13:08:08 *** ChanServ sets mode: +v tokai 13:08:11 *** snail_UES_ has quit IRC 13:15:08 *** tokai|noir has quit IRC 13:37:40 *** Thedarkb-T60 has quit IRC 13:39:59 *** andythenorth has joined #openttd 13:42:39 <andythenorth> o/ 13:45:37 *** Thedarkb-T60 has joined #openttd 13:46:10 <Eddi|zuHause> you don't want to know what happened to the last finnish guy who looked for the translation manager... 13:49:47 <Heiki> eek 13:51:40 *** nielsm has joined #openttd 14:01:23 <Samu> I have a dilema 14:01:54 <andythenorth> hmm 14:02:02 <andythenorth> is newgrf completion pareto compliant? 14:02:09 <andythenorth> I am nearly at 80% 14:02:21 <andythenorth> which might suggest I'm less than halfway 14:03:22 <Eddi|zuHause> very likely 14:03:53 <Samu> can there be multiple pull requests per issue? 14:04:11 <Samu> or shall I post them in the same pull request? 14:04:36 <Samu> I have 2 patches here https://github.com/OpenTTD/OpenTTD/pull/6925/commits/64040f3a1ff0b6917e474edcbd62214c8db16d84 14:04:54 <Samu> oops, not this link 14:05:09 <LordAro> same pull request, preferably 14:05:10 <Samu> https://github.com/OpenTTD/OpenTTD/issues/6574 here 14:05:30 <Samu> but the title :( 14:05:49 <LordAro> wait, is that 2 separate solutions to the same issue? 14:05:56 <LordAro> (PR titles can be changed) 14:06:12 <Samu> no, but they can go along together fine 14:07:47 <Samu> the go to takeoff if no hangar prevents the helicopter being stuck at the heliport 14:07:56 <Samu> at the airport 14:09:01 <Samu> the other, will make the orders go to hangar to disappear when replacing an airport with another without hangar 14:09:36 <Samu> or was it (Invalid Order) 14:09:43 <Samu> something like that, I can't recaçç 14:09:45 <Samu> rcall 14:11:43 <Samu> they complement each other, but is not required to have both for it to work 14:12:02 <Samu> so i dunno if i make a separate pull request 14:13:29 <Samu> as for the savegame conversion, I didn't do anything about it 14:13:39 <Samu> loading old saves where helicopters are stuck, will remain stuck 14:14:40 <Samu> i'm not confident enough to fix that 14:17:31 *** Wormnest has joined #openttd 14:21:05 <LordAro> i'd probably say the same pull request then 14:21:19 <LordAro> it can always be removed 14:37:26 <Samu> that means, complement it? 14:37:53 <Samu> it would be patched upon the first one 14:38:06 <LordAro> yeah 14:38:31 <Samu> but they could be separate 14:38:37 <Samu> hmm oh well 14:38:47 <LordAro> but they fix the same issue 14:38:54 <Samu> ok 14:38:55 <Samu> ok 14:39:06 <Samu> so be it 14:39:16 <LordAro> it doesn't make much of a difference (it's git, branches & commits are cheap) 14:39:22 <LordAro> but that's my opinion 14:40:59 *** Alberth has joined #openttd 14:40:59 *** ChanServ sets mode: +o Alberth 14:41:09 <Alberth> hi hi 14:41:37 *** Wacko1976 has joined #openttd 14:41:53 <andythenorth> lo Alberth 14:42:23 <Alberth> hola andy 14:52:44 <Samu> hmm, Change or Fix? 14:53:02 <Samu> i hate commit messages, slows me down too much :p 14:54:11 <Samu> feels more like a change rather than a fix 14:54:37 <Samu> guess I'll go with fix 14:55:39 <Samu> help, i can't make my mind up 14:57:08 *** Thedarkb-T60 has quit IRC 14:57:31 *** Thedarkb-T60 has joined #openttd 15:02:28 <Samu> there it goes... https://github.com/OpenTTD/OpenTTD/pull/6925 15:06:50 *** Flygon has quit IRC 15:09:16 *** Wacko1976-work has quit IRC 15:31:05 *** Wormnest has quit IRC 15:33:56 *** Thedarkb-T60 has quit IRC 15:54:11 *** Thedarkb-T60 has joined #openttd 15:54:52 *** OtakuSenpai has quit IRC 15:56:32 *** sla_ro|master has joined #openttd 16:24:13 *** Gja has joined #openttd 16:30:37 <Samu> I got a weird error just now 16:31:15 <Samu> https://imgur.com/rRtHeB1 16:31:57 <Samu> that was AdmiralAI server 16:32:06 <Samu> for the AI competition 16:32:13 <Samu> think it's the first time I've ever seen that happening 16:33:33 <Samu> from an AI 16:34:25 <Samu> server log: *** Player has left the game (desync error) 16:36:34 <Samu> Player is me, I was only spectating 16:36:40 <Samu> no company 16:36:41 *** TheMask96 has quit IRC 16:37:44 <Samu> unsure if hibernation could have caused it, system was resumed from yesterday night 16:38:22 *** TheMask96 has joined #openttd 16:38:48 <Samu> but all the other 7 openttds are still spectating 16:39:01 <Samu> only this one desynced :( 16:45:29 <Samu> doesn't matter much, I'm in again 16:45:56 <LordAro> ooh, that's interesting 16:46:00 <LordAro> desync errors shouldn't happen ever 16:46:36 <Samu> b/src/station_cmd.cpp:2459: Use tabs for indentation: ' dock.' 16:46:43 <Samu> wtf is a indentation 16:46:49 <Samu> brb google 16:47:04 <andythenorth> oof 16:47:27 <LordAro> andythenorth: ikr 16:47:44 <andythenorth> I am not a lot better 16:49:35 <Samu> ah, I see 16:49:38 <Samu> a missing asterisc 16:49:40 <Samu> really... 16:55:36 <Samu> why is it failing now? 16:55:47 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6927/commits/817053eb2f3fb3fdccb56284f4765b37af9e4572 16:55:56 <Samu> the asterisk is there 16:56:03 <Samu> still complains about the same thing 16:57:55 <Samu> enters panic mode :| 16:57:59 <Samu> halp 16:58:53 *** Wolf01 has joined #openttd 16:58:58 <Alberth> moin 16:59:06 <Wolf01> o/ 16:59:36 *** gnu_jj has quit IRC 16:59:39 <andythenorth> Samu: tabs vs spaces 16:59:46 <andythenorth> your editor is inserting spaces probs 16:59:49 <andythenorth> but you need tabs 17:01:17 <LordAro> andythenorth: i think it's probably the other way round, given what line it's on 17:01:23 <LordAro> tabs after spaces 17:01:49 <LordAro> there will be a button somewhere to show tabs and spaces 17:02:16 <andythenorth> oof 17:02:59 <Samu> the editor is Atom 17:03:29 <Samu> let me open in Notepad++ 17:05:08 <Samu> they're all spaces 17:05:47 <Samu> seems that the commit checker dude only care about the first commit 17:08:05 <Samu> not familiar with Atom, but it seems that they're all spaces too 17:08:16 <Samu> it's the commit checker dude! 17:12:21 <Samu> what must I do now? the rebase interactive refix again? 17:15:22 <andythenorth> probably 17:15:42 *** Gja has quit IRC 17:25:57 *** Wormnest has joined #openttd 17:26:17 *** gnu_jj has joined #openttd 17:31:49 <LordAro> Samu: i'd recommend it 17:33:15 <Samu> ok, i'm on it 17:33:32 *** Progman has joined #openttd 17:35:24 <Samu> oh i forgot the last command 17:35:38 <Samu> pushing with force 17:36:10 <Samu> git push -f isn't it? 17:36:13 <LordAro> yup 17:37:09 <Samu> great, I'm becoming a pro in this Lol 17:37:34 <Samu> or maybe not? :( 17:38:00 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6927 er i better wait 17:38:14 <Wolf01> More pro than me for sure :P 17:38:26 <LordAro> "The commit looks good" 17:38:33 *** frosch123 has joined #openttd 17:38:49 <Samu> i saw 3 commits for a second 17:38:53 <Samu> now it's 1 17:39:05 <Samu> weird stuff happening in the background 17:40:01 <andythenorth> quak 17:40:13 <LordAro> Samu: yeah, that's github 17:40:18 <LordAro> if things look weird, refresh 17:40:59 <frosch123> moi 18:04:01 *** sushibear_ has quit IRC 18:24:25 *** wodencafe has quit IRC 18:30:44 *** gelignite has joined #openttd 18:34:11 <frosch123> in case someone missed it: redmine runs again 18:41:45 <Samu> can't i have that docker dude on my system? 18:42:00 <Samu> he likes to fail my commits 18:42:14 <Samu> so instead of failing there, it fails here 18:46:12 <LordAro> you actually can 18:46:17 <LordAro> well, mostly 18:47:06 <LordAro> https://github.com/OpenTTD/OpenTTD-git-hooks basically, copy the contents of the hooks directory into <ottd checkout>/.git/hooks 18:49:18 <andythenorth> frosch123: \o/ 18:49:43 <andythenorth> hmm was that why jenkins won't log me in? 18:50:02 <andythenorth> hmm no 18:50:25 <frosch123> no, it was just redmine 18:50:51 <frosch123> disk was full, deleted the logs, 1/3 free again 18:51:21 <frosch123> repeat in 8 years 18:51:35 <andythenorth> ha 18:51:42 <andythenorth> wonder what's up with jenkins :P 18:51:58 <frosch123> jenkins always had manual user setup iirc 18:52:01 <frosch123> so only few can login 18:53:07 <andythenorth> has anyone considered a new build farm? o_O 18:53:15 <andythenorth> maybe TrueBrain has an opinion :P 18:53:47 *** glx has joined #openttd 18:53:47 *** ChanServ sets mode: +v glx 18:54:38 <frosch123> i think i started a cxfreeze farm to build nml binaries 18:54:46 <frosch123> probably did not get far :p 18:56:06 *** wodencafe has joined #openttd 18:56:24 <Samu> this .git directory must be hidden 18:56:31 <Samu> i blame windows 18:56:32 <LordAro> yeah 18:56:37 <LordAro> well, it is normally 18:56:49 <LordAro> (files starting with . are hidden on linux as well) 18:57:50 <Samu> woah windows 10 made showing hidden files much simple 18:59:06 <Samu> there's a bunch of *.sample files here 18:59:31 *** sla_ro|master has quit IRC 18:59:52 <LordAro> you can ignore those 18:59:58 <LordAro> they are, as you might guess, samples 19:02:48 *** Wacko1976 has quit IRC 19:06:48 <Samu> tortoise svn is telling me there's 2 failed hunks but is not showing me them, grr 19:07:01 <LordAro> probably because you're using svn :p 19:07:07 <LordAro> i promise you can apply patches with git 19:07:26 <LordAro> well, i guess it's not because you're using svn 19:07:28 <LordAro> but it doesn't help 19:07:43 <Samu> i'm applying them on trunk, then move entire src into github version 19:07:55 <LordAro> ew 19:08:03 <glx> easier to apply in git 19:08:25 <Samu> it complains about end of line stuff for a while, but then Atom magically makes that disappear 19:08:38 <Samu> and only leaves me with the changes I made 19:10:11 <LordAro> Samu: run `git config --global core.autocrlf true` in git bash/cmd 19:10:29 <LordAro> and then stop using svn :p 19:13:09 <LordAro> also try git kraken 19:15:44 *** Wormnest has quit IRC 19:17:05 <Samu> I did that, but nothing seemed to happen 19:18:10 <LordAro> it should help with things in future 19:18:18 <LordAro> (it tells git how to handle line endings) 19:28:35 *** Wacko1976 has joined #openttd 19:28:52 *** sushibear has joined #openttd 19:28:54 *** synchris has quit IRC 19:43:00 <andythenorth> so 19:43:23 <andythenorth> electric engine pantographs 19:46:06 <andythenorth> are missing in original game 20:00:14 *** muetD has joined #openttd 20:00:15 *** Alberth has left #openttd 20:00:25 <muetD> hello 20:04:50 <nielsm> hi 20:08:48 <andythenorth> is it BAD FEATURES if electric engine pantograph only goes up on elrail? 20:09:07 <andythenorth> it's utterly pointless, as they won't be powered on non-elrail :P 20:13:01 *** gelignite has quit IRC 20:14:23 <nielsm> that would be a good detail to pay attention to imo 20:14:50 <andythenorth> it's not very hard to do 20:14:53 <andythenorth> just adds complexity 20:38:55 *** nielsm has quit IRC 20:43:01 *** rocky113844 has joined #openttd 20:43:17 *** andythenorth has left #openttd 20:58:41 *** jjavah0lic has joined #openttd 21:05:06 *** Progman has quit IRC 21:05:53 *** jjavah0lic has quit IRC 21:06:54 *** frosch123 has quit IRC 21:18:24 <Samu> I'm preparing a yapf, npf, opf pull request 21:18:32 <Samu> what would the tittle be? 21:18:47 <Samu> Fix/Feature? 21:20:14 <Samu> Fix #5713: [YAPF/NPF/OPF] ? 21:20:18 *** Thedarkb-T60 has quit IRC 21:20:37 <Samu> Fix #5713: [YAPF/NPF/OPF] Use pathfinder to find closest ship depot 21:20:42 <Samu> good title? 21:21:34 <Samu> or is it a feature? 21:25:04 <LordAro> just drop the [...] 21:25:31 <acklen> beat? 21:25:42 <LordAro> ;) 21:25:58 <Samu> ok 21:26:31 <Samu> Fix #5713: Use pathfinder to find closest ship depot 21:26:42 <LordAro> sure 21:26:43 <Samu> pathfinders 21:26:47 <Samu> or just pathfinder 21:26:50 <LordAro> can always be renamed :p 21:27:09 <LordAro> singular is fine, imo 21:27:24 <Samu> ok 21:30:32 <Samu> alright, let's see if the docker thing works locally 21:30:59 <Samu> Commit failed - exit code 1 received, with output: 'Don't run this script from the command line. (if you want, you could supply GIT_DIR)' 21:31:09 <Samu> what is this 21:31:15 <LordAro> (don't call it the docker thing, that's something else (basically just compiles it on lots of different OSes) 21:31:18 <LordAro> uh 21:31:39 <Samu> commit checker 21:32:45 <Samu> this is an error i got when i clicked commit on github desktop 21:32:55 <Samu> local 21:33:23 <Samu> wait, let me show 21:33:24 <LordAro> i bet that's github desktop screwing with it 21:33:27 <LordAro> try git gui 21:33:31 <glx> not sure the commit checker can run on windows 21:33:42 <Samu> https://imgur.com/W8z631c 21:34:01 <Wolf01> 'night 21:34:04 *** Wolf01 has quit IRC 21:34:42 <LordAro> i think glx is right 21:34:47 <LordAro> might work in git bash 21:37:39 <Samu> was hoping I wouldn't have to use command line stuff for everything 21:37:40 <LordAro> otherwise you'll have to delete those files you put in .git/hook 21:40:13 <Samu> deleted 21:41:06 <LordAro> you'll just have to learn to amend & rebase instead :p 21:41:14 <LordAro> or get it right the first time ;) 21:45:50 <Samu> hmm NPF is a damn jack of all trades 21:47:44 <Samu> okay i got a dilema 21:48:10 <Samu> i implemented a max_penalty for all pathfinders 21:48:16 <Samu> opf only deals with ships 21:48:24 <Samu> but npf is the problem 21:49:05 <Samu> i had to adapt that max_penalty also for trains and road vehicles 21:49:16 <Samu> code rework kind of thing 21:49:42 <Samu> yapf, on the other hand had it already implemented for trains, but not for road vehicles, this patch implements it for ships 21:49:47 <Samu> what should I do? 21:50:34 <Samu> to make npf find closest ship depot, it uses this penatly, but apparently it would also be used for road vehicles and trains 21:50:53 <Samu> can't do it without the penatly 21:51:37 <Samu> while the patch mainly focus on fixing ships, i had to touch the other parts :| 21:51:45 <Samu> erm... confused? 21:51:52 <LordAro> is there an existing issue? 21:51:58 <LordAro> or pull request 21:52:03 <LordAro> if so, ask there 21:52:12 <LordAro> someone will get around to answering it at some point 21:52:39 <LordAro> it also shows that someone's thought about the issue 21:54:47 <Samu> i also have writen code for the yapf road vehicle max penalty, not sure if I put it in? yapf is different than npf in that it can be separated 21:55:54 <Samu> my dilema is "if I did it for npf, why not for yapf as well" 21:56:21 <Samu> it's road 21:56:25 <Samu> that's why 21:56:34 <Samu> and the patch is about ships, not roads 21:58:07 <Samu> well, i'll post all of it 21:58:15 <Samu> hope u guys have a really good code reviewer 22:05:12 <Samu> mm nah, i'm gonna make this a different pull request for yapf 22:13:22 *** rocky11384497 has joined #openttd 22:15:51 *** Wacko1976 has quit IRC 22:17:16 *** rocky113844 has quit IRC 22:48:13 *** Wacko1976 has joined #openttd 23:03:11 <Samu> arf... this is a hg patch 23:03:18 <Samu> can't use svn 23:04:05 *** acklen has quit IRC 23:05:35 <Samu> problem solved