Log for #openttd on 8th April 2019:
Times are UTC Toggle Colours
00:00:20  <Samu> active_scripts is the only uint there
00:00:27  <Samu> the others are doubles
00:02:46  <Samu> GL_RATE is 33.3333333333
00:03:30  <Samu> maybe all > GL_RATE isn't triggering yet
00:04:33  <Samu> over 30.00 ms is already displayed as red, but I'm only doing subtractions at 33.33
00:05:26  <Samu> i fail to see why
00:05:57  *** Corns343434 has joined #openttd
00:08:14  <Samu> oh, interesting, target is actually 30.0000000
00:08:30  <Samu> i thought it was the same as GL_RATE
00:08:37  <Samu> where or how is this 30 coming from
00:08:45  *** glx has quit IRC
00:09:55  <peter1138> MILLISECONDS_PER_TICK?
00:10:34  <Samu> ah, I see, looks like that's it
00:11:10  <Samu> so what I want is MILLISECONDS_PER_TICK, not GL_RATE
00:11:13  <Samu> fixing, brb
00:11:55  *** HerzogDeXtEr has quit IRC
00:13:13  <Samu> MILLISECONDS_PER_TICK is a uint, hmmm
00:14:15  <Corns343434> What places can i ask somebody to help me draw a tool icon?
00:17:45  *** Thedarkb-X40 has joined #openttd
00:28:54  <Samu> strange, the parameters aren't loaded as they were set
00:29:53  *** tokai|noir has joined #openttd
00:29:53  *** ChanServ sets mode: +v tokai|noir
00:34:15  <Samu> random deviation is broken
00:34:25  <Samu> or maybe it's not that
00:34:39  <Samu> must investigate
00:36:59  *** tokai has quit IRC
00:38:38  <Samu> the settings with CONFIG_RANDOM | CONFIG_INGAME are the ones affected
00:39:01  <Samu> when i start a game, from main menu, no random occurs
00:39:25  <Samu> if i save the game and then load it back, those settings are randomized on load
00:39:34  <Samu> that's wrong
00:46:52  <Samu> I think AnchorUnchangeableSettings should anchor CONFIG_RANDOM settings
00:47:22  <Samu> unsure
00:48:06  *** Flygon has joined #openttd
00:55:33  <Samu> yep, that was it
01:31:33  <Corns343434> How do i go about adding my own custom sprites to the game? Eg if i was making a pull request to trunk
01:33:27  <nnyby> I think you can make changes to the OpenGFX sprite set here:
01:33:53  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
01:38:42  *** Corns343434 has quit IRC
01:39:31  *** Corns343434 has joined #openttd
01:45:20  <Samu> there's still another problem, related
01:47:39  *** Supercheese has quit IRC
01:48:00  *** Supercheese has joined #openttd
01:52:30  *** Corns343434 has quit IRC
01:52:47  *** Corns343434 has joined #openttd
01:52:57  <Corns343434> nnyby thank you :)
01:57:10  <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #7188: Both server and client crash, AI related
01:59:17  *** Corns343434 has quit IRC
02:38:46  *** debdog has joined #openttd
02:42:09  *** D-HUND has quit IRC
02:44:42  <nnyby> my ships keep saying they're lost but they're not >_<
02:50:10  <nnyby> these ships are making a profit.. vehicles can recover from getting lost, but then get lost again following the same path? hmm..
02:57:51  <Samu> from what I know, the "lost ship feature" was removed on master
02:58:21  <Samu> it was a distance check between ship position and destination
02:59:46  <Samu> it was done to prevent calling the pathfinder every tile
03:00:03  <Eddi|zuHause> tried changing the pathfinder?
03:00:19  <nnyby> i am playing on master. i havent tried changing the pathfinder
03:00:46  <nnyby> i did see peter removed the ship max order distance, which is nice
03:01:24  <Samu> this AnchorUnchangeableSettings fix is probably the wrong fix, I found another way
03:10:34  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
03:11:49  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
03:12:12  <Samu> now im off to bed
03:12:13  <Samu> cyas
03:12:18  *** Samu has quit IRC
05:47:36  <DorpsGek_II> [OpenTTD/OpenTTD] ghisvail commented on issue #6873: Jukebox not working in the flatpak version
05:55:29  *** andythenorth has joined #openttd
06:00:26  <andythenorth> o/
06:04:55  <LordAro> but yes
06:17:56  *** Supercheese has quit IRC
06:18:17  *** Supercheese has joined #openttd
06:32:48  *** Supercheese has quit IRC
06:33:09  *** Supercheese has joined #openttd
06:35:24  <DorpsGek_II> [OpenTTD/website] auge8472 commented on issue #77: Download links in header too long
06:44:13  *** Supercheese has quit IRC
08:15:49  <andythenorth> done
08:26:16  <planetmaker> I... got a reply by DaleStan on my Factorio bug report oO
08:26:30  <planetmaker> the world is tiny
08:26:31  <Xaroth> o_O
08:26:59  <andythenorth> DaleStan lives!
08:27:38  <peter1138> andythenorth, what's different?
08:27:54  <peter1138> It looks good.
08:27:56  <andythenorth> peter1138: pixels
08:28:16  <andythenorth> previous
08:28:55  <andythenorth> what shall I draw next?
08:28:55  <peter1138> nnyby, wrong advice about adding custom sprites to the game, though.
08:29:07  <andythenorth> I have 3 big newgrf projects
08:29:19  <peter1138> Ah yes, those round buttons are better.
08:29:20  <andythenorth> and drawing a little bit for each keeps them nicely far away from finished
08:29:38  <peter1138> Heh
08:29:48  <andythenorth> sounds familiar? o_O
08:29:57  <Xaroth> andythenorth: you know this perhaps, but tech trees possible with newgrf (plus/minus usage of GS)
08:30:10  <andythenorth> eh?
08:30:11  <Xaroth> Or is that wishful thinking
08:30:18  <andythenorth> wishful
08:30:20  <Xaroth> aw
08:31:18  <Xaroth> That could be neat
08:31:26  <andythenorth> tech tree would be best handled by OpenTTD
08:31:39  <andythenorth> newgrf could do it, but it would be specific to each newgrf, so quite weird
08:31:57  <andythenorth> GS can't do it, because GS is hopeless
08:32:18  <andythenorth> tech trees would answer the majority of daylength wishes, afaict
08:52:53  *** andythenorth has quit IRC
09:04:11  <peter1138> What would a tech-tree look like in OpenTTD?
09:05:08  *** andythenorth has joined #openttd
09:06:52  <peter1138> He's back.
09:11:41  <LordAro> peter1138: like a low res jpeg screenshot of civ3's tech tree
09:12:19  <peter1138> Ok, look wasn't the right word :P
09:12:25  <peter1138> How would a tech tree fit in?
09:16:40  <andythenorth> some kind of epoch / era per vehicle
09:16:42  <andythenorth> or a score
09:16:49  <andythenorth> and then the game advances them at a default rate
09:16:52  <andythenorth> which triggers intro
09:17:11  <andythenorth> default rate is obvs. 1 tech tree year = 1 year
09:17:24  <andythenorth> then let GS manipulate the current state of tech
09:17:42  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7431: Fix aa7ca7fe6: Linkgraph node index order must be maintained due to other references.
09:17:43  <andythenorth> bonus points: let industries and houses also understand it
09:19:38  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7452: Fix 6fc60d8c4f: forgot to update API changelog
09:20:05  <peter1138> Ok, I'm going to stop commenting.
09:23:30  <peter1138> So there's 3 commits marked for backport that have not been merged into master yet.
09:24:33  <andythenorth> 1.9.1
09:24:40  <andythenorth> or something :P
09:25:36  <peter1138> Marking things for backport when they don't affect 1.9 is not particularly useful :/
09:25:46  <andythenorth> :D
09:28:08  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7487: Backport marked PRs to 1.9.1
09:28:49  <peter1138> planetmaker, so please don't do that ;)
09:29:06  <peter1138> Oh I missed one.
09:31:02  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7487: Backport marked PRs to 1.9.1
09:47:18  *** Flygon_ has joined #openttd
09:48:30  <andythenorth> so given the orders of a train, we should be able to predict statistically the route it will take?
09:48:46  <andythenorth> so we'd know the maximum grade?
09:49:07  <andythenorth> so we could calculate HP-per-ton and the resulting speed over the grade?
09:49:10  <andythenorth> we probably shouldn't :P
09:49:16  <andythenorth> sledgehammer -> nut
09:49:55  <peter1138> Eh what?
09:50:14  <peter1138> Which nut are you trying to crack?
09:50:16  <andythenorth> prompted by
09:50:50  <andythenorth> I just run a train over the route, and add more engines if it's too slow :P
09:52:09  <peter1138>  /win 18
09:52:12  *** Flygon has quit IRC
10:05:05  <planetmaker> peter1138, yes, not yet. But when they are, they are bug fixes which need backporting
10:05:26  <planetmaker> so ... as it's a thing often overlooked I thought it a good idea to mark them straight away
10:05:58  <peter1138> Backporting to what?
10:06:30  <planetmaker> to 1.9.x. Whether that is 1.9.1 or later. In the assumption that the suggested fixes get merged soonish
10:06:52  <peter1138> But you marked things for backport which don't affect 1.9.
10:08:04  <planetmaker> Like which?
10:09:20  <peter1138> #7471, #7456, #7452, #7431
10:09:39  <peter1138> #7435 and #7419 are okay though :)
10:15:08  <planetmaker> hm, well. sorry
10:16:03  <peter1138> Yeah, I'm evaluating my choices  here :p
10:16:20  <peter1138> It's good to have things marked as otherwise we would miss important fixes.
10:16:42  <peter1138> And it was easy for _me_ know the ones which are not relevant.
10:16:58  <planetmaker> I looked at what they fixed... but obviously I was not exactly awake
10:21:19  <peter1138> Hmm, testing out a 32" screen. Somewhat large, aren't they?
10:21:23  <peter1138> 2560x1440
10:23:14  <andythenorth> oof
10:23:19  * andythenorth lives in a 13" world
10:23:31  <peter1138> It's not HiDPI though, so I can't test that 4k issue ;)
10:24:08  <planetmaker> hm, 32" and only 2560x1440?
10:24:38  <planetmaker> One of my monitors quit on me the other day... now I'm pondering to replace both... by larger ones
10:24:47  <peter1138> Definitely doesn't need to be on a stand to raise it.
10:25:14  <planetmaker> or just taking one big one... but hm
10:25:18  *** planetmaker has left #openttd
10:25:21  <peter1138> Yes, pixel size  is pretty good though, about equivalent to 23" 1080p.
10:25:23  *** planetmaker has joined #openttd
10:25:23  *** ChanServ sets mode: +o planetmaker
10:25:26  <peter1138> Yes, pixel size  is pretty good though, about equivalent to 23" 1080p.
10:25:45  <peter1138> If I was buying one for myself I'd want 4k though.
10:26:31  <peter1138> Or 5k? I think Apple have 5k screens.
10:27:28  <andythenorth> they sell an LG or something
10:28:08  <peter1138> 5120x2880
10:28:29  <peter1138> I think 32" is too big!
10:28:37  <peter1138> I'm going to get neck strain.
10:30:14  <planetmaker> move your chair backwards :)
10:30:40  <peter1138> Yeah perhaps.
10:30:46  <planetmaker> will be a total win... moving so far back that the bigger screen has the same viewing angle as the old, smaller one :P
10:31:13  <peter1138> 1080 -> 1440 is much more of an improvement than I'd imagined, though.
10:31:36  *** planetmaker has left #openttd
10:31:41  *** planetmaker has joined #openttd
10:31:41  *** ChanServ sets mode: +o planetmaker
10:31:43  <planetmaker> gah
10:32:28  <peter1138> :)
10:32:49  <planetmaker> don't browse and chat :P
10:33:35  <peter1138> heh
10:33:47  <peter1138> So my issue is I currently have 3x 22" 1680x1050 monitors at home.
10:34:09  <peter1138> If I get wider monitors, I can only fit 2x in.
10:34:12  <planetmaker> upright or landscape?
10:34:16  <peter1138> Landscape.
10:34:22  <planetmaker> that's pretty wide :)
10:34:33  <peter1138> It's pretty good for driving games :-)
10:34:37  <planetmaker> he
10:34:47  <peter1138> Also good for developing OpenTTD.
10:34:51  <planetmaker> for openttd 1024 x 256 maps :P
10:35:11  <peter1138> I tend to run things in half-width full-height windows.
10:35:15  <planetmaker> see everything concurrently... it's interesting
10:35:24  <peter1138> So I get 6 views concurrently.
10:35:44  <peter1138> Usually a source view, a compilation view, or git/tig output.
10:35:45  <planetmaker> yo, for dev many screens is gold
10:35:48  <peter1138> IRC on another screen :)
10:35:51  <planetmaker> ^^
10:36:10  <peter1138> But yeah, if I dropped back to 2 screen, I'd have a horrible bezel right in the middle.
10:36:58  <planetmaker> doesn't matter for dev... but yes, car racing :D
10:39:29  <peter1138> To be fair, since I got back into OpenTTD coding, I really haven't done anything much else.
10:39:37  *** andythenorth has left #openttd
10:39:47  <planetmaker> it quickly eats a lot of time
10:44:14  <peter1138> Hmm, maybe I should test #7484 on this screen
10:44:39  <peter1138> Maybe I should do some work.
11:09:28  <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison opened pull request #7488: Fix: Crash due to use of invalid iterator in ClientNetworkContentSocketHandler
11:20:57  <peter1138> Github is quite nice at 1280x1440 :-)
11:35:56  <peter1138> Hmm, not sure on #7460, two ways to fix it, one like in the PR, and the other is as in my comment.
11:35:58  <milek7>
11:40:14  <milek7> does it work? there should be one server available
11:42:07  <V453000> where is our train photo specialist Mr. North
11:45:10  <peter1138> It loaded but the music was loud in the office so I had to close it :p
11:46:43  <V453000> seems to work
11:47:36  <milek7> multiplayer too?
11:47:43  *** planetmaker has left #openttd
11:47:49  *** planetmaker has joined #openttd
11:47:49  *** ChanServ sets mode: +o planetmaker
11:48:12  *** Samu has joined #openttd
11:48:26  <V453000> didn't try that, already closed :d
11:49:30  <Samu> hi
11:59:37  *** pnda has joined #openttd
11:59:52  <pnda> Why do I feel like a lot of devs have strange monitors
12:01:56  <pnda> Like peter said 1280x1440. Is that not 3:4?
12:03:04  <V453000> well you usually say x first and that's not 4:3 I think :)
12:03:14  <V453000> so suspicion is in place :D
12:03:28  <pnda> 0,89:1 ... uhh
12:05:41  <peter1138> No, it's not 4:3 :p
12:06:05  <peter1138> It's also half the screen.
12:06:25  <pnda> So what is the total resolution?
12:06:46  <peter1138> 2560x1440
12:07:02  <peter1138> Not excessive for 32"
12:07:18  <pnda> 1440p is quite normal at 32"
12:07:28  <pnda> I'm getting a 1440p with 29"
12:07:52  <peter1138> Colours are very vibrant. Hmm.
12:08:11  <pnda> So I guess a IPS screen?
12:08:15  <peter1138> Yeah.
12:08:22  <peter1138> Viewsonic VX3211-2K-mhd
12:09:37  <pnda> Ah that one.. relatively mid-level but good
12:10:08  <peter1138> Yeah, mid-range.
12:11:13  <pnda> With my next update I'll have 3 screens, 1x 2560x1440, 1x 2560x1080, 1x 1920x1080... Yes a quite weird setup
12:11:16  <V453000> that's what I suspected :)
12:12:29  * peter1138 has 3x 1680x1050 at home. Very old-school.
12:12:53  <pnda> You're at work? huh and yes that's quite an oud
12:13:00  <pnda> oudated setup*
12:13:31  <LordAro> it still displays stuff, doesn't it?
12:13:39  <peter1138> Mostly :)
12:13:53  <LordAro> not outdated then :p
12:14:04  <peter1138> And I'm not using VGA with any of them, so that's a plus.
12:14:24  <Xaroth> I'm using 2x 2560*1440p, the amount of space it gives is awesome :P
12:15:14  <pnda> I love 1440p, but I sadly only have the money for one high-end 1440p monitor so I decided to keep my 2 current ones and mount the current main above to the wall
12:15:16  <peter1138> I might consider moving my computer elsewhere so I can upgrade.
12:15:35  <peter1138> Or just drop back to 2 screens.
12:15:55  * LordAro has 3x1080p
12:15:55  *** pnda has quit IRC
12:15:58  <LordAro> at work
12:16:04  <LordAro> 2x1080p, 1x1440p at home
12:16:26  *** pnda has joined #openttd
12:25:25  *** pnda has quit IRC
12:28:02  <Samu> startai command in the console is tricky
12:30:39  <peter1138> Ah, hitting the sprite cache limit kills performance, heh
12:36:36  <Samu> do you remember that last random deviation fix?
12:37:44  <Samu> for some reason, when start date is a value other than 0 and the ai is random ai, no random deviation occurs
12:37:54  <Samu> and should occur
12:38:33  <Samu> looks like last fix, fix one thing, but broke another
12:38:37  <Samu> t.t
12:42:58  <Samu>
12:46:27  *** pnda has joined #openttd
12:51:13  *** Lejving_ has joined #openttd
12:54:25  <Samu> this is so complex to follow
13:34:02  <pnda> Do fields from farms have any special name? sub-industries?
13:39:55  <peter1138> "fields" ;)
13:40:25  <pnda> Well they could be unified
13:40:37  <peter1138> The tile type is the same as a clear type.
13:40:42  <peter1138> The tile type is the same as a clear tile.
13:40:57  <peter1138> Unified with what and why?
13:41:36  <pnda> Why not let a industry, from a GRF, specify a special type of tile that works just like fields and gets placed randomly in a radius of the industry
13:42:34  <planetmaker> @ pnda
13:43:13  <pnda> Ahhhh wasn't this already a thing with industry behaviour?
13:43:36  <LordAro> pnda: you might find that a lot of the answers to your questions are "because no one has done it yet"
13:44:11  <LordAro> oil rigs are the other obvious example
13:47:25  <Samu> field fences are the 2nd most cpu intensive from tileloop
13:47:38  <Samu> first being water flood
13:48:59  <Samu> englsih?
13:51:04  <planetmaker> was what I actually looked for @ pnda
13:51:14  <planetmaker> but it's related :P
13:52:03  <planetmaker> That callback 3B does not exactly exist (yet)
13:52:29  <planetmaker> to the extend described there
14:02:58  <_dp_> ffs asrock, 2h driver download :(
14:03:16  <_dp_> modern file sizes dont mix well with 90s speeds
14:03:28  <V453000> it's called rock made out of ass for a reason :P
14:03:43  <V453000>  /me has assus
14:04:01  <V453000> idk what is it with motherboard manufacturers and ass obsession
14:04:16  <V453000> I will see myself out.
14:04:38  <_dp_> it probably mean something cool in chinese :)
14:06:14  <V453000> something along the lines of ass
14:06:46  <pnda> ffs asus giving me a broken gpu... I think that's worse than a long driver download ^^
14:07:43  <pnda> planetmaker: does frosch still work on CB 3B & is whats done available in trunk/master?
14:08:10  <planetmaker> I don't think so. It's a collection of ideas
14:08:36  <planetmaker> master allows industries to plant fields. Or trees. But you knew that.
14:08:42  <planetmaker> that is done via CB 38
14:08:47  <planetmaker> err. 3B
14:08:50  <Samu> after furher investigation, looks like random deviation fix didn't break anything, just tested without that fix, and it still happens. It was already there
14:08:55  *** HerzogDeXtEr has joined #openttd
14:09:58  <Samu> the bug was already present even before the fix
14:10:43  <Samu> so the bug is this:
14:10:47  <Samu> set up random AIs
14:10:52  <Samu> start new game
14:11:16  <Samu> random deviation doesn't occur for start_date even when it's not 0
14:22:12  *** WWacko1976-work has quit IRC
14:23:20  *** sla_ro|master has joined #openttd
14:23:33  <Samu> i fail at understanding what the heck SettingValueList::const_iterator is doing
14:24:13  <Samu> but this is the thing where start_date is sometimes pulled out, and some other times not
14:26:50  <Samu> this->settings[stredup((*it).first)] = (*it).second;
14:27:15  <Samu> stredup((*it).first) is "start_date"
14:27:23  <Samu> but this->settings has a size of 0
14:27:27  <Samu> something doesn't feel right
14:28:36  <Samu> what would this->settings["start_date"] be getting if this->settings is size=0 ?
14:31:01  *** Lejving_ has quit IRC
14:34:53  *** Wormnest has joined #openttd
14:36:24  <LordAro> Samu: it's a map, it automatically creates new entries
14:37:49  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7270: Introduce CMake (and removing all other project-related code)
14:39:47  <Samu> I see
14:42:58  *** nielsm has joined #openttd
14:43:55  <Samu> there's ScriptConfigItemList::const_iterator
14:44:08  <Samu> and there's SettingValueList::const_iterator
14:44:27  <Samu> too easy to get confused
14:45:41  <nielsm> nothing to be confused about, they're different types
14:49:33  <Xaroth> hm
15:03:22  *** synchris has joined #openttd
15:03:53  *** Flygon_ has quit IRC
15:16:48  <Samu> ScriptConfigItemList doesn't contain "start_date" on Random AIs, so when random valuator is called, it doesn't do anything about it
15:16:56  <Samu> random deviation*
15:17:28  <Samu> doesn't find it
15:17:38  <Samu> how to fix?
15:37:52  <peter1138> Do we do a RC for 1.9.1?
15:39:22  <nielsm> if it's just bug fixes and it looks safe imo not
15:39:27  <pnda> If at all only one I'd say
15:39:49  <nielsm> if it turns out to introduce new bugs then fast-track 1.9.2
15:40:10  <peter1138> Would be good to release tonight as it's 1 week after 1.9.0 ;)
15:41:30  <pnda> Would all backport-requested PRs then get merged?
15:42:54  <Samu>     map() : _Mybase(key_compare()) { // construct empty map from defaults
15:43:00  <Samu> where is this map?
15:43:13  <Samu> this is so obscure
15:43:22  <nielsm> it's part of the C++ standard template library
15:43:34  <peter1138> pnda, only if they're already merged into master.
15:44:00  <Samu> or maybe a better question, where does it get the defaults?
15:44:09  <peter1138> Hmm, doing the changelog is awkward. The commit messages by themselves usually lack context and make no sense for a public list.
15:45:46  <peter1138> Ah, #7483 could be backported too.
15:45:51  <peter1138> If it's merged.
15:53:17  <Samu> -		config_list	{ size=??? }	std::list<ScriptConfigItem,std::allocator<ScriptConfigItem> >
15:53:21  <Samu> -		config_list	0xcdcdcdcdcdcdcdcd { size=??? }	std::list<ScriptConfigItem,std::allocator<ScriptConfigItem> > *
15:53:25  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7487: Backport marked PRs to 1.9.1
15:53:38  <Samu> there are 2 config_lists
15:53:50  <Samu> and then there still settings
15:54:01  <Samu> 3 lists with pretty much the same thing
15:54:05  <Samu> so confusing
16:14:35  <V453000> bottom version, aye?
16:14:43  <V453000> ofc colours and textures not final
16:14:51  <V453000> just deciding design
16:15:00  <nielsm> bottom looks nicer
16:24:14  *** Hobbyboy|BNC has joined #openttd
16:24:15  *** Hobbyboy has quit IRC
16:24:28  *** Hobbyboy|BNC is now known as Hobbyboy
16:28:42  <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison commented on issue #7481: Fast forwarding very fast can cause window.cpp/kdtree.hpp crash
16:29:46  *** Alberth has joined #openttd
16:29:46  *** ChanServ sets mode: +o Alberth
16:29:48  <Samu> line 77 of script_config.cpp is failing to do what's supposed to be doing
16:29:51  <Alberth> o/
16:30:12  <Samu> this->PushExtraConfigList(); should add the start_date to the config_list
16:30:35  <Samu> 	virtual void PushExtraConfigList() {};
16:30:40  <Samu> it does nothing :(
16:31:45  <Alberth> it's virtual, a derived class may be doing something
16:32:31  <Alberth> although I fail to see how a function PushExtraConfigList() would do anything with start_date
16:32:37  *** Progman has joined #openttd
16:32:54  <Samu> this->config_list->push_back(_start_date_config);
16:32:57  <Samu> should do this
16:33:18  <Samu> but that one is void AIConfig::PushExtraConfigList()
16:35:22  <peter1138> Oh my god my 1680x1050 screens feel tiny now :(
16:36:38  <Samu> new AIConfig(_settings_newgame.ai_config[c]); this is the root function
16:39:06  <Alberth> got a bit spoiled peter :)
16:40:31  <V453000> 3440 x 1440 master race <3
16:40:46  <nielsm> I kind of want a non-wide screen for coding on...
16:41:24  <nielsm> (someone is going to respond "get a gigantic display and split it in halves")
16:42:16  <peter1138> If it's big enough, that does work really well.
16:43:12  <Alberth> rotate it 90 degrees niels?
16:43:43  <milek7> hm, emscripten sdl2 video output is slow on higher resolutions, 20ms+
16:45:41  <nielsm> Alberth that tends to become too tall for comfort
16:45:58  <peter1138> I find the subpixel arrangement irritating if the screen is rotated.
16:46:11  <nielsm> 2048x1536 would be a good display size
16:46:35  <Alberth> 2nd hand shops perhaps
16:47:40  <peter1138> If you're lucky you might find 1600x1200.
16:47:41  <Alberth> and nobody said you have to use the entire height :)
16:48:27  <nielsm> at work I do have one display in vertical
16:48:27  <peter1138>
16:49:09  <nielsm> rather expensive, but then it is eizo
16:49:40  <peter1138> Probably an old model anyway.
16:50:41  <nielsm> "Date First Available	20 Oct. 2013"
16:50:52  <peter1138> Oh not that bad.
16:51:05  <peter1138> Probably missing quite a chunk of cost-saving tech, though.
16:51:17  <nielsm> now if just they would begin making OLED panel computer displays
16:51:32  <nielsm> instead of reserving the tech for 10 inch tablets and 53 inch televisions
16:51:36  <nielsm> and nothing in-between
16:53:06  <peter1138> Heh
16:54:24  *** Smedles_ has joined #openttd
16:54:27  * peter1138 tests 7484.
16:54:44  <peter1138> Minor improvement already on ProZone 13.
16:54:53  <peter1138> Which doesn't have too much going on.
16:55:37  <V453000> nice game to test with :P
16:55:38  <peter1138> Graphics rendering drops about .75ms
16:56:07  <peter1138> Emperor Jake's NetTrans is good for this patch, I think
16:56:22  *** pnda has quit IRC
16:56:31  <peter1138> If you can find all the NewGRFs...
16:56:42  *** Smedles has quit IRC
16:57:16  <peter1138>
17:01:22  *** Wolf01 has joined #openttd
17:01:41  <peter1138> Ahmm, 61ms -> 55ms
17:02:01  <peter1138> That's half-width.
17:02:04  * peter1138 tries full screen.
17:02:19  <Wolf01> o/
17:02:28  <peter1138> Still only about 5ms.
17:02:41  <peter1138> Hmm, less now it's settling.
17:03:45  <peter1138>
17:03:49  <peter1138> Oh god my eyes.
17:05:29  <V453000> h8 zbase? :P
17:06:07  <planetmaker> only thing it's missing is some shading on vehicles
17:06:12  <Eddi|zuHause> you mean the jpeg artifacts, right?
17:06:35  <peter1138> Shading. Detail. Correct sizing...
17:06:39  <peter1138> Quite a lot missing.
17:06:48  <peter1138> It's a shame I can't draw for shit.
17:06:57  <planetmaker> no. That's just not your graphics style
17:07:01  <Eddi|zuHause> is that a donkey or a horse on the plaza?
17:07:40  <planetmaker> judging all graphics by "is it sufficiently similar to ttd" won't cut it. It's a bit ... pop art style
17:07:42  <nielsm> isn't the statue a spider?
17:07:43  <nielsm> :)
17:08:05  <nielsm> (in original graphics)
17:08:20  <planetmaker> here it is a fossil dinosaur :P
17:08:57  <Alberth> I was thinking mule :)
17:09:23  <Eddi|zuHause> so something between "both" or "neither"?
17:09:35  <Alberth> likely :p
17:09:43  <peter1138> I'm just judging it by "does it look good"
17:09:50  <peter1138> And that is, IMHO, no.
17:10:55  <Eddi|zuHause> that's the weird thing, some things don't need to be good to find their target audience
17:11:09  <peter1138> Quite. See Brexit.
17:12:02  <Eddi|zuHause> is that actually happening now?
17:12:13  <peter1138> Hmm, well, 7484 is marginally faster on this game, so that's something.
17:12:51  <Alberth> it may be simpler to have another election about it, and it gets voted 'no' :p
17:13:49  <peter1138> Did you hear one of the Hard-brexiters in the government is now... calling for a revote... because we know more now... and the outcome would be different...
17:13:52  <peter1138> But not on Brexit, no.
17:14:03  <peter1138> On the no-confidence motion in their leader.
17:14:11  *** andythenorth has joined #openttd
17:14:41  <Alberth> o/
17:15:00  <Alberth> planetmaker: unsticky the titlescreen competition thread?
17:15:33  <planetmaker> good point
17:16:41  <peter1138> Hmm, now this patch is about 4K resolutions being slow.
17:16:49  <Alberth> lol
17:16:56  <peter1138> I'm on 1680x1050, so kinda... not comparable.
17:17:38  <Eddi|zuHause> try zooming out?
17:18:02  <peter1138> Yeah, it's about 4K resolutions being slow when zoomed out...
17:18:14  <Eddi|zuHause> try zooming out further? :p
17:18:50  <V453000> I did notice massive slowdown when zooming to 0.5
17:18:56  <V453000> 3440 x 1440
17:19:12  <Eddi|zuHause> V453000: thanks for volunteering as test subject :p
17:19:14  <V453000> so not full 4k
17:19:23  <andythenorth> o/
17:19:34  <peter1138> That might just be sprite cache size.
17:19:37  <V453000> I'd love to test, but you'll need to show me how  to build openttd on windows first :P
17:19:38  <andythenorth> what's slow?
17:19:45  <peter1138> This particular issue is with lots of overlapping sprites, stressing the sprite sorter.
17:20:59  <Eddi|zuHause> so, like, bridges?
17:21:15  <Eddi|zuHause> trucks in towns with large buildings
17:21:28  <peter1138> Well, not overlapping.
17:21:34  <peter1138> Just lots of sprites. They all need sorting.
17:22:03  <Eddi|zuHause> i'm assuming non-overlapping is harder to get into worst-case sorting?
17:22:27  <peter1138> I guess l
17:22:29  <peter1138> ...
17:22:31  <peter1138>
17:27:07  <peter1138> Hmm, it was FIRS that broke before.
17:28:17  <peter1138> Nope, still broken.
17:28:25  <andythenorth> FIRS did what to you now?
17:28:29  <andythenorth> delete it!
17:28:53  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7484: Codechange: Sprite sorting optimization
17:29:34  <peter1138> Well that solves that dilemma :p
17:30:55  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
17:31:20  <Samu> well, that PR fixes 2 things now :|
17:32:58  <Samu> took me a while to understand where the problem was
17:37:47  <Samu> this->info == NULL aka I'm a random AI, i think
17:38:50  <Samu> ScriptConfig constructor thing doesn't construct the start_date in random AI
17:39:04  <Samu> so there was no setting at all to deviate
17:40:25  <Samu> PushExtraConfigList calls the AI version of the function which adds the "start_date"
17:40:41  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7460: Fix #6222: Advanced sprite layout sometimes showed incorrect railtype ground tile.
17:40:55  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7460: Fix #6222: Advanced sprite layout sometimes showed incorrect railtype ground tile.
17:41:10  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7460: Fix #6222: Advanced sprite layout sometimes showed incorrect railtype ground tile.
17:41:17  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #6222: Stations: using property 1A sometimes shows incorrect railtype ground tile
17:41:49  <Samu> AddRandomDeviation then calls the AI version of the function which already does the right thing, so that's why it doesn't run the 2nd part of the code
17:42:48  <peter1138> Many spam.
17:43:56  <andythenorth> at least 7
17:44:17  <peter1138> Well, I can't backport things which are merged yet. Hmm.
17:44:38  <Samu> does this PR deserve backporting?
17:45:17  <peter1138> *aren't
17:45:29  <Samu> probably not
17:45:45  <Samu> start_date = 0 isn't a thing in 1.9
17:47:12  *** frosch123 has joined #openttd
17:47:33  <Samu> is this in 1.9.0 ?
17:47:47  <Samu> makes no sense if it is because start_date = 0 isn't
17:48:14  <peter1138> Samu, all your crap was already reverted for 1.9
17:48:41  <Samu> where is it
17:50:20  <Samu>
17:50:23  <Samu> it's in 1.9
17:50:29  <Samu> that wasn't reverted
17:51:04  *** gelignite has joined #openttd
17:51:38  <peter1138> Oh well.
17:51:49  <peter1138> You're the only person using AIs like that anyway.
17:51:55  <peter1138> So it hardly matters.
17:52:16  <Samu> hehe
17:52:45  <peter1138> So are we merging #7480 or not?
17:52:54  <peter1138> LordAro?
17:54:30  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7480: Fix #6666: arabic town directory strings
17:56:26  *** Wormnest has quit IRC
17:56:39  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7487: Backport marked PRs to 1.9.1
17:59:32  *** pnda has joined #openttd
17:59:40  <peter1138> Do I reset APPV_BUILD from 4 to 0 for 1.9.1?
17:59:54  <pnda> peter1138 Would the PR not have to be renamed if those two strings are fixed?
18:00:05  <peter1138> pnda, I have no idea.
18:00:25  <peter1138> Doesn't necessarily need to be fixed there, just mentioned it as related.
18:00:44  <pnda> I can fix it there, would be easier to oversee
18:05:49  <LordAro> peter1138: might as well
18:07:07  <peter1138> 6 PRs backported now o_O
18:07:10  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
18:07:48  <andythenorth> anyone drawn the Carbon Black Plant for FIRS yet? o_O
18:09:31  <peter1138> "Action 4 has feature 48 'original strings'"
18:09:39  <peter1138> Doesn't really translate well to a changelog :p
18:10:17  <LordAro> "fix: newgrf station strings did not display"
18:10:24  <LordAro> ?
18:10:24  <nielsm> "Action 4 feature 48 strings were not being loaded from NewGRFs causing various bugs"
18:10:27  <peter1138> Not just stations :-)
18:10:37  <LordAro> some newgrf strings...
18:10:38  *** chomwitt has joined #openttd
18:10:41  <LordAro> :p
18:11:19  <peter1138> Missing NewGRF strings due to Action 4 feature check skipping pseudo-feature 48
18:11:20  <peter1138> Pom te pom.
18:11:23  <peter1138> Not quite. But.
18:12:27  <frosch123> "make newgrf older than 2010 work again"
18:12:38  <peter1138> :p
18:12:49  <nielsm> make newgrf old again
18:13:00  <nielsm> old new grfs
18:13:33  <peter1138> < and that? :p
18:14:23  <peter1138> There's some open PRs tagged for backport. Anyone dare approve them?
18:14:59  <peter1138> Might be getting into 1.9.2 territory.
18:15:11  <peter1138> They're not exactly critical thouhg.
18:15:46  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7483: Fix #7478: Don't remove NewGRF objects on company take-over.
18:16:58  <nielsm> Fix: [Windows] Error in error handling could lead to erroneous error boxes
18:17:14  <LordAro> :D
18:17:24  <Wolf01> Lol
18:17:30  <nielsm> Fix: [Windows] Incorrect error handling could lead to cascading error boxes
18:18:42  <Samu> and bsod
18:18:46  <Samu> j/k
18:18:47  <peter1138> - Fix: [Windows] Incorrect error handling could lead to cascading error windows (#7482)
18:18:50  <peter1138> Going with that.
18:20:30  <peter1138> Is #7478 safe enough to backport? Seems quite simple to me.
18:20:46  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7478: Newobject disapears if company owner get buyed by another company
18:20:47  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7483: Fix #7478: Don't remove NewGRF objects on company take-over.
18:21:13  <nielsm> it's probably fine
18:26:48  <andythenorth> 'probably fine' is the best
18:28:14  <pnda> Seems I fixed the other arabic strings
18:28:20  <pnda> Are there any other known ones?
18:30:56  <pnda> ok these are still broken...
18:36:56  <pnda> How the hell did this happen
18:37:16  <LordAro> i think you broke it
18:38:04  <pnda> uhhhh
18:39:50  <pnda> How the hell did this happen though
18:40:18  <LordAro> well those look like strgen errors
18:40:24  <LordAro> so the lang file has been mangled in some way
18:40:35  <pnda> I know... but it isn't shown by VS
18:40:39  <pnda> GitHub Desktop shows this
18:40:53  <LordAro> bet that's a BOM
18:41:21  <pnda> Well i just stashed it
18:41:24  <pnda> I'll redo it
18:41:38  <LordAro> aiui VS does like to add BOMs sometimes
18:41:48  <pnda> Didn't use VS Code
18:41:52  <pnda> Only touched this file with VS
18:43:10  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7487: Backport marked PRs to 1.9.1
18:43:25  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7487: Backport marked PRs to 1.9.1
18:44:27  <TrueBrain> sorry peter1138, seems I am incapable of switching branches before hitting 'git push' :(
18:44:33  <pnda> Now why thell is it skipping building the .exe
18:44:54  <peter1138> Uh..
18:45:46  <TrueBrain> change rename the PR: stuff for 1.9.1, and you will be fine :P
18:46:58  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7487: Backport marked PRs to 1.9.1
18:47:58  <andythenorth> it's TrueBrain !
18:48:05  <pnda> It even shows correctly
18:48:59  <peter1138> I've got the "release 1.9.1" PR with the changelog done as well.
18:49:21  <TrueBrain> yeah, my commits should have gone in that one I guess :D
18:49:32  <peter1138> Does not matter.
18:49:45  <TrueBrain> not really, no
18:50:32  <peter1138> The backport_1.9 stuff also included the translations, and they are backports, so it's all good.
18:50:43  <TrueBrain> yeah, I mostly did everything from a single branch :P
18:50:52  <pnda> whyyyyyyy is the VS formatting soooooo bad
18:52:27  <pnda> 6>Project not selected to build for this solution configuration
18:53:11  <Samu> use Notepad++
18:53:22  <pnda> to compile?
18:53:39  <pnda> lol don't even have notepad++
18:53:40  <Samu> no, to avoid those weird vs additions
18:53:43  <Samu> bom stuff
18:53:56  <pnda> they aren't happening now
18:54:00  <pnda> And have never happened
18:54:04  <pnda> so I'll leave it
18:56:46  <Samu> i need an AI that makes use of random deviation in one of its settings
18:56:55  <Samu> eh, might as well be mine, brb
18:58:55  *** glx has joined #openttd
18:58:55  *** ChanServ sets mode: +v glx
18:59:06  *** Alberth has left #openttd
18:59:35  <pnda> thiiissss iss annoying meeeeeeeee
19:03:55  <peter1138> All checks passed...
19:04:43  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7487: Backport marked PRs to 1.9.1
19:05:11  <peter1138> Scared
19:05:13  <pnda> Whyyyy do I have to rebuild each time
19:05:39  <pnda> I seem to have a fix but that requires to have {BLACK} inbetween each part of the string
19:05:45  <TrueBrain> just don't forget to update the labels or something peter1138 :)
19:05:56  <peter1138> Yeah
19:06:05  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7487: Backport marked PRs to 1.9.1
19:08:19  <peter1138> Like that.
19:08:46  *** synchris has quit IRC
19:08:48  <TrueBrain> missed ?
19:08:57  <TrueBrain> and nice :)
19:09:14  <peter1138> Ah
19:09:25  <peter1138> Was another page :D
19:10:05  <andythenorth> shall we ship the website?
19:11:55  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7489: Update: Changelog for 1.9.1 and prepare for release
19:12:36  <peter1138> So... I hope I got everything :p
19:13:01  <TrueBrain> looks okay to me
19:13:06  <TrueBrain> hopefully LordAro likes your changelog :D
19:13:09  <peter1138> Oh.
19:13:16  <peter1138> I missed one.
19:13:39  <milek7> TrueBrain: have you seen new emscripten build, with network? :)
19:14:03  <TrueBrain> link to patch?
19:14:16  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7489: Update: Changelog for 1.9.1 and prepare for release
19:14:31  <peter1138> OS2 installer. Probably doesn't even work, mind you...
19:15:08  <TrueBrain> orudge promised to look at it :P
19:16:03  <milek7>
19:16:51  <TrueBrain> that is no patch :)
19:17:16  <peter1138> Maybe it needs no patching? :LD
19:18:02  <peter1138> So pressing the "Exit" button stops the game but leaves the music running.
19:18:23  <milek7>
19:18:52  <TrueBrain> and that works without some proxy?
19:19:00  <TrueBrain> wasm allows raw network sockets?
19:19:40  <milek7> no, it requires proxy
19:19:59  <TrueBrain> how does that look like?
19:20:15  <TrueBrain> most of that patch can be upstreamed without much issue, so that is nice
19:21:30  <peter1138> Ah yeah, sockets only work to the server hosting it, right?
19:22:06  *** gelignite has quit IRC
19:22:18  <nielsm> so you could still make a wrapper (docker?) that runs an ottd-dedicated and serves a wasm version up
19:22:33  <peter1138> So that `` -> `` change... ought to be improved.
19:22:58  <milek7> you can use other servers, but must be websocket and https
19:23:27  <milek7>
19:23:57  <peter1138> I was just going to say, is the proxy available or some proprietory glue that you keep to yourself to be evil ;D
19:24:11  <peter1138> #7489 passes, woo.
19:24:25  <peter1138> Did I do it right? :p
19:24:31  <milek7> ordinary websocket proxies don't work because it must redirect to proper tcp/udp from single websocket port
19:24:59  <TrueBrain> nice work milek7 :)
19:25:11  <TrueBrain> I don't see any real blockers to move this to tbh :)
19:26:04  <milek7> sdl video output annoys me, it gets much slower at higher resolutions
19:26:08  <milek7> i need to look into it
19:27:28  <TrueBrain> I still think that would be cool to add to the site .. :D
19:27:33  <TrueBrain> but does need cloud storage tbh :P
19:28:18  <milek7> saving in browser storage isn't enough? ;p
19:28:25  <TrueBrain> it "works" :P
19:29:11  <peter1138> Hmm.
19:29:14  <peter1138> Cloud stroage.
19:29:34  <pnda> I can't seem to fix this
19:29:37  <TrueBrain> what is the average savegame size, give or take?
19:30:40  <peter1138> #7489 for review? ;)
19:31:23  <TrueBrain> if someone else can look at the changelog; I am fine with the rest
19:34:11  * peter1138 sips a bit of birthday Whiksy.
19:34:43  <pnda> Ok I can actually not fix these arabic strings :(
19:35:31  <milek7> "most of that patch"
19:35:33  <milek7> ^ so there's something that couldn't be upstreamed?
19:35:33  <pnda> also annoying I have to rebuild the solution each time
19:35:35  <nielsm> you'll probably need to LRE marks for that pnda
19:35:43  <pnda> possibly
19:35:50  <pnda> didn't have to for the town directories though
19:35:56  <V453000> _dp_: how the hell did you get into a circumstance of making a map with that many stations? :D some script went nuts?
19:35:58  <nielsm> and huh? you shouldn't need to rebuild anything other than a single language file when not changing english.txt
19:36:15  <pnda> when I just do a build
19:36:19  <pnda> it skipps creating the .exe
19:36:22  <pnda> for some reason
19:36:31  <nielsm> yeah that one doesn't need updating
19:36:37  <peter1138> V453000, pretty sure it's a script, and deliberate :-)
19:36:38  <nielsm> the language data are in external files
19:36:51  <pnda> right.... stupid me
19:37:05  <V453000> deliberate WHY :D WTF (:
19:37:13  <peter1138> For testing? heh
19:37:23  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7489: Update: Changelog for 1.9.1 and prepare for release
19:37:24  <TrueBrain> Yolo!
19:37:34  <peter1138> haha
19:37:41  <pnda> Ok I found a way to fix this. But this requires removing one part of the string.... hmm
19:37:52  <TrueBrain> to avoid waiting for hours :P
19:38:01  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7489: Update: Changelog for 1.9.1 and prepare for release
19:38:08  <peter1138> Okay now what.
19:38:14  <LordAro> tag!
19:38:15  <V453000> RUN.
19:38:17  <V453000> :D
19:38:21  <TrueBrain> GitHub -> Releases -> Create -> 1.9.1
19:38:21  <pnda> Just having قياسي) نوع المحرك) results in that bug, if I remove the first part its normal
19:38:24  <peter1138> LordAro was here! Just hiding!
19:38:32  <TrueBrain> he didnt want to read some changelogs
19:38:33  <TrueBrain> the hate
19:38:36  <LordAro> peter1138: i'm always watching
19:38:46  <TrueBrain> <- Draft New Releases
19:38:46  *** pnda has quit IRC
19:38:48  <TrueBrain> to be more exact
19:38:56  <TrueBrain> select the right commit
19:38:58  <TrueBrain> ;)
19:39:49  <peter1138> So... "1.9.1" @ "Target: release/1.9" ?
19:40:01  <TrueBrain> sounds good
19:40:31  <peter1138> Hmm, draft or "publish release" ?
19:40:42  <peter1138> Cos I'm scared ;)
19:41:00  <TrueBrain> publish :)
19:41:23  <TrueBrain> looks good
19:41:29  <TrueBrain> now it is just: wait :)
19:41:31  <peter1138> DorpsGek_II, y u no notification
19:41:42  <TrueBrain> kicked in
19:41:46  <TrueBrain> yeah ... that needs fixing
19:41:52  <peter1138> Btw, in my 15 years of OpenTTDing, this is my first release.
19:41:57  <TrueBrain> and don't forget to follow :)
19:41:59  <TrueBrain> gratz :D
19:42:10  <peter1138> Oh now you tell me lol
19:42:29  <TrueBrain> it helps to tell what to do after release, at least, for me
19:42:33  <peter1138> :D
19:42:36  <TrueBrain> I always forget something .. like IRC :P
19:42:44  <peter1138> @openttdnews. Hmm..
19:43:12  <TrueBrain> basically, poke planetmaker
19:43:15  <TrueBrain> which most likely will forget :P
19:43:48  <TrueBrain> @topic set 0 1.9.1
19:43:48  *** DorpsGek changes topic to "0 1.9.1"
19:43:50  <TrueBrain> oops
19:43:51  <TrueBrain> :D
19:43:59  <TrueBrain> I knew I would fuck that up some day :P
19:44:13  <TrueBrain> meh .. this client doesnt say what the topic was
19:44:52  <TrueBrain> @op TrueBrain_
19:44:52  *** DorpsGek sets mode: +o TrueBrain_
19:44:59  *** TrueBrain_ changes topic to "1.9.1 | Website: * (source: github, translator: translator, server list: servers, wiki: wiki) | Don't ask to ask, just ask | 'Latest' is not a valid version, 'Most recent' neither | English only"
19:45:10  <TrueBrain> @deop TrueBrain_
19:45:10  *** DorpsGek sets mode: -o TrueBrain_
19:46:39  <DorpsGek_II> [OpenTTD/OpenTTD] jmakovicka updated pull request #7484: Codechange: Sprite sorting optimization
19:47:08  <Samu> I'm still unsure about that deviation being prevented
19:47:54  <peter1138> Hmm, so, news message on the website :/
19:48:36  <_dp_> just thought of ultimate color challenge: sorting socks after washing
19:48:42  <Samu> this->info != NULL also means random ais are being ignored, and they have start_date as a valid deviator
19:48:44  <_dp_> way more difficult than that xrite thing
19:48:53  * _dp_ doesn't get perfect score on socks :(
19:49:18  <DorpsGek_II> [OpenTTD/OpenTTD] jmakovicka commented on pull request #7484: Codechange: Sprite sorting optimization
19:50:21  *** pnda has joined #openttd
19:51:03  <pnda> When is the website going up for 1.9.1?
19:53:24  <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7453: Remove AutoDeleteSmallVector and AutoFreeSmallVector
19:54:27  <pnda> Also, for the arabic strings: If I have ({ArabicWord}) {ArabicWord2}, the first bracket will ALWAYS go to the end of the string, due to it not being attached to the arabic words.
19:54:50  <pnda> If I were to remove the {ArabicWord2}, the string would work fine.
19:58:24  <pnda> But I guess I'll have to this tomorrow.... So good night
19:59:06  *** pnda has quit IRC
20:01:02  *** nielsm has quit IRC
20:09:15  <TrueBrain> heffer: we release 1.9.1 :) Just as a friendly poke :)
20:11:45  <milek7>
20:12:11  <milek7> it ignores dirty areas and copies always whole frame ;/
20:18:15  <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on pull request #7350: Change: Add pid, file, line number & function/procedure name to debug messages
20:34:59  <peter1138> ah.
20:35:04  <peter1138> Bah.
20:35:17  <peter1138> Got water pipe issues :(
20:38:02  <peter1138> Great, my VM won't boot.
20:38:03  <peter1138> Hmm.
20:39:04  <peter1138> Alright, now it's running. Odd :p
20:40:16  <andythenorth> sunspots
21:07:08  <Samu> 1.9.1 is out?
21:07:23  <Samu> 1.9.0 was short lived :(
21:07:43  <LordAro> ":("
21:07:50  <LordAro> does everything make you sad?
21:09:35  <Samu> :( no
21:09:37  <Samu> hehe
21:09:46  <Samu> just a bad habit
21:12:16  *** Progman has quit IRC
21:12:53  <DorpsGek_II> [OpenTTD/website] PeterN opened pull request #78: Add: Release post for 1.9.1
21:15:33  <LordAro> random thought, should it link to latest.html, or 1.9.1.html ?
21:17:03  *** Wolf01 has quit IRC
21:17:28  <planetmaker> I'm torn. But in a release posting probably to the specific version?
21:18:00  <LordAro> but equally we don't want people looking at old release posts and downloading old versions
21:18:04  <LordAro> (necessarily)
21:18:05  <planetmaker> and... orudge already replyed very friendly
21:18:06  <peter1138> I copied the last one, so...
21:18:47  *** sla_ro|master has quit IRC
21:28:07  <Xaroth> "there are no bugs left"
21:28:15  <Xaroth> that's optimistic :P
21:31:15  <Samu> random deviance is computed twice for start_date in some occasions, but the 2nd time it is done, it no longer matters
21:31:26  <Samu> it's an ai starting
21:32:09  <Samu> doesn't matter which value it gets after it is started
21:33:37  <Samu> or does it?
21:33:37  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7490: Add: Press ctrl to build diagonal rivers in scenario editor.
21:33:40  <DorpsGek_II> [OpenTTD/website] michicc approved pull request #78: Add: Release post for 1.9.1
21:34:42  <Samu> saving game and loading it back with a different value than that it was used to start with
21:35:25  *** Supercheese has joined #openttd
21:36:05  <andythenorth> also bed
21:36:17  *** andythenorth has left #openttd
21:38:05  <DorpsGek_II> [OpenTTD/website] PeterN merged pull request #78: Add: Release post for 1.9.1
21:43:37  <peter1138> "For rail types a number of callbacks are used to define rail type graphics"
21:43:47  <peter1138> Why does the NML spec call it a "callback"? o_O
21:44:33  <Supercheese> Hysterical raisins
21:47:36  <_dp_> damn, wanted to make first 1.9.1 server but someone beat me to it %)
21:48:18  <_dp_> still the first open one :p
21:48:25  <LordAro> heh
21:52:28  * peter1138 installs OpenTTD 1.9.1
21:52:55  <peter1138> Damn, TrueBrain is a massive hero. This CI and deployment stuff is so cool.
21:53:44  <Samu> this start_date parameter is utterly difficult to track down
21:54:16  <peter1138> _dp_, "If you're new to your servers please read" ...
21:54:38  <peter1138> Okay that map is far to boring and flat for me.
21:54:43  <Samu> I wonder, would it be a good idea to get rid of it?
21:54:49  <peter1138> And not enough water for ships to be fun.
21:55:33  <Samu> there's too many corner cases where it doesn't work as it should
21:59:17  <_dp_> peter1138, oh, ty
21:59:27  <_dp_> peter1138, you're the first one to read that message I guess xD
21:59:29  <Samu> ok, here's a new issue: when a Random AI is set up, starting a new game will do a random deviation for start_date. Then when the AI actually starts in game, random deviation is done again for start_date + any other settings the randomly chosen AI has
21:59:48  <Samu> how to avoid doing it a 2nd time?
22:00:06  <_dp_> peter1138, and idk about 1.9 but before ships it mp weren't fun at all ;)
22:00:23  <_dp_> peter1138, also it's an easy game mode for new players
22:00:33  <Samu> avoid doing it for start_date only, but do for the other settings
22:00:57  <_dp_> peter1138, and it have a goal that provides enough extra entertainment
22:01:39  <Samu> wondering if this is caused by my last fix, reverting, brb
22:02:47  <peter1138> Ships are definitely no fun when the only water is a few small lakes.
22:04:22  <_dp_> peter1138, even if there was water ships don't rly have a purpose on goal servers
22:04:32  <_dp_> peter1138, exept for abusing them by stacking in a small pond
22:06:12  <_dp_> though even that is quite pointless for such an easy goal
22:06:48  <Xaroth> hm
22:07:07  <Xaroth> bankruptcy counter update isn't sent to the admin port
22:07:41  <_dp_> you mean how long is company in negative?
22:07:42  *** HerzogDeXtEr has quit IRC
22:07:46  <Xaroth> yes
22:08:13  <Samu> it was my fix :(
22:08:21  <_dp_> well, a lot of stuff isn't sent I guess
22:08:35  <Xaroth> Most of it is sent in ServerCompanyStats/ServerCompanyEconomy
22:08:36  <Samu> fixes one thing, but breaks somewhere else
22:09:09  <_dp_> I'm not even using normal admin port anymore, wrote my own protocol %)
22:09:34  <Xaroth> meh, the Admin Port has been stable for at least 6 years now, so that has to count for something
22:09:38  <Xaroth> maybe not bug-free, but still
22:11:12  <peter1138> Well, there's ways to get things fixed.
22:11:20  <peter1138> Bug reports, or even better, PRs.
22:12:05  <_dp_> peter1138, I don't even know what I'm doing with it, hard to make a reasonable PR like that :p
22:12:09  <LordAro> Xaroth: tbf, "stable" != "useful"
22:12:19  <Xaroth> True
22:12:52  <glx> Samu: you already did something for the start_date
22:13:23  <Xaroth> I was contemplating adding an example to libottdadmin2's rework to use the admin port for a simple read-only API
22:13:45  <Samu> I'll write in the PR, cus this is all too difficult to track down
22:14:05  <_dp_> peter1138, I did some custom binary thing to record games then I didn't like something in admin port so I thought hey, I have binary thing and it would be cool but instead of using that thing I made a new thing because it's going to be better except it's not yet...
22:14:18  <peter1138> Err? What?
22:14:19  <_dp_> tldl it's a mess xD
22:14:40  <peter1138> I was kinda talking to Xaroth :p
22:15:12  <Xaroth> peter1138: the word 'json' was missing somewhere in that sentence
22:17:08  <Xaroth> but more, tomorrow, nn
22:17:31  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame.
22:17:49  <peter1138> Right, bug closing time.
22:18:14  *** gnu_jj has quit IRC
22:19:01  <peter1138> Hmm, how do I reference the release in an issue? :p
22:19:11  <peter1138> Referencing its PR feels wrong.
22:19:35  <LordAro> link to the news post :p
22:19:51  <LordAro> there's no builtin GH way, afaict
22:20:42  <dwfreed> you could set the milestone
22:20:58  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7476: Can't Refit Certain NewGRF Trains (undefined string error)
22:20:59  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7476: Can't Refit Certain NewGRF Trains (undefined string error)
22:21:01  <dwfreed> but that's not quite the same
22:21:06  <peter1138> Eh, well, that's shitty too.
22:21:25  *** gnu_jj has joined #openttd
22:21:43  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7466: New GRF Stations Not Showing Up
22:21:44  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7466: New GRF Stations Not Showing Up
22:21:58  <peter1138> I think those were the only two.
22:23:04  <TrueBrain> LordAro: always link to latest. someone that finds the news of 1.9.0 for example you want him to download 1.9.1 .. people rarely want one specific version. all news posts always point to latest for this reason
22:23:12  <TrueBrain> as a FYI :)
22:23:33  <TrueBrain> and tnx peter1138, happy to see the effort was worth it :)
22:27:00  <Samu> yeah glx, that start_date = 0 just adds more trouble to the already troubled start_date
22:27:13  <Samu> pff little did I know
22:30:49  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7484: Codechange: Sprite sorting optimization
22:33:13  <Samu> start_date deviation must occur for random AI when MakeNewgameSettingsLive on openttd.cpp is called
22:34:10  <Samu> for getting the next AI starting time
22:34:13  <Samu> correctly
22:35:03  <Samu> it's how it works when there's an actual script selected
22:36:41  <peter1138> Hmm, maybe sleep.
22:37:13  <Samu> so that 2nd thing I fix is needed, but then, ai_core.cpp, when actually starting a random ai, picks one randomly from the available list and performs a Change right before anchoring unchangeable settings
22:38:39  <Samu> line 51 ai_core.cpp
22:39:26  <Samu> how to solve
22:41:41  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7051: Feature: Moveable depots #6328
22:48:49  *** frosch123 has quit IRC
23:04:41  *** Wormnest has joined #openttd
23:19:49  <LordAro> oh, when did it become tomorrow?
23:19:51  * LordAro slep
23:27:10  <peter1138> Oh shit
23:27:18  <peter1138> It did didn't it.
23:27:30  <peter1138> So much for early night :(
23:28:07  <heffer> TrueBrain: thanks. working on the update just now :)
23:29:59  *** Wormnest has quit IRC
23:33:42  <Eddi|zuHause> wait, really? these tomorrows seem to always sneak up on you
23:42:04  <heffer> Here it is still tonight. So we're all good
23:43:28  <heffer> Also TrueBrain's release notifications are faster than Fedora's: [5:09:16 p.m.] <fedora-notif> A new version of "openttd" has been detected:  "1.9.1" newer than "1.9.0", packaged as "openttd"
23:44:43  <luaduck> howdy, does still get updated?
23:44:58  <luaduck> I think it's detached from github or something, it still shows 1.8.0 as being the latest version
23:45:02  <luaduck> breaks my build script
23:45:11  <peter1138> I think you answered your own question.
23:46:11  <luaduck> it'd be annoying, but I could probably reengineer my script to check git tags
23:46:26  <peter1138> There's another metadata source, but I don't remember where.
23:46:35  <luaduck> finger was (is?) just a convenient way of doing that in a scrapable way
23:48:37  <_dp_> ppl still complain about cursor on windows...
23:49:33  <glx> finger has been replaced I think
23:49:43  <peter1138>
23:50:05  <peter1138> _dp_, yup, we haven't changed anything about it, so no surprise that it's not fixed.
23:51:19  <_dp_> peter1138, there was something about it in 1.8 iirc
23:51:20  <luaduck> peter1138: ta
23:52:03  <glx>
23:52:11  <glx> for all details
23:54:46  <peter1138> Yeah, treat that URL as temporary, I guess.
23:55:39  <peter1138> _dp_, not that I know of.
23:56:47  <_dp_> peter1138, mb it was cursor locking
23:57:20  <_dp_> peter1138, I just remember there was cursor-windows-something xD
23:58:06  <_dp_> in the past n years....
23:58:14  * _dp_ being very informative...

Powered by YARRSTE version: svn-trunk