Times are UTC Toggle Colours
02:11:42 *** Zuu has quit IRC 02:39:23 *** Supercheese has joined #openttd.dev 03:16:29 *** Supercheese has quit IRC 03:17:01 *** Supercheese has joined #openttd.dev 03:36:23 *** FLHerne_ has quit IRC 08:58:38 *** Alberth has joined #openttd.dev 08:58:38 *** ChanServ sets mode: +v Alberth 09:08:46 *** Supercheese has quit IRC 09:14:58 *** planetmaker is now known as planetifex 09:15:11 *** planetifex is now known as planetmaker 11:20:03 *** frosch123 has joined #openttd.dev 11:20:03 *** ChanServ sets mode: +v frosch123 11:30:01 *** ntoskrnl has joined #openttd.dev 11:38:57 *** Zuu has joined #openttd.dev 11:38:57 *** ChanServ sets mode: +v Zuu 12:47:52 *** ChanServ changes topic to "OpenTTD Dev Channel || Latest SVN: r25007 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 13:52:17 *** FLHerne has joined #openttd.dev 14:08:41 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25008 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:15:32 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25009 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:21:12 *** FLHerne has quit IRC 14:35:07 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25010 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:49:20 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25011 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:53:16 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25012 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:57:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25013 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:05:58 *** ntoskrnl has quit IRC 17:30:29 *** fonsinchen has joined #openttd.dev 17:30:29 *** ChanServ sets mode: +v fonsinchen 17:32:16 <fonsinchen> woohoo! You've merged the reservation thing. 17:34:36 <fonsinchen> Unfortunately you've also merged a bug I've just discovered this morning ... :/ 17:35:56 <fonsinchen> The "waiting" figure in UpdateStationRating can actually be > ge->cargo.Count(). In that case we should not truncate. Otherwise we get an overflow and truncate to 0. 17:36:14 <fonsinchen> I'll open a report for that. 17:41:03 <Rubidium> well, I reckon people will find even more bugs in it (like they do in almost everything) 17:42:11 <fonsinchen> Yes, there are probably a few more bugs in there as it hasn't been tested for very long. 17:42:34 <fonsinchen> The later commits have been pretty stable for about a year. I don't think there are many bugs left in them. 17:46:24 <Rubidium> hmm... the SmallMapWindow refactor does a 'class' refactoring, and some other code changes. That's a pity 17:54:13 <fonsinchen> I needed to clean that up a bit to allow for the unified treatment of smallmap and viewport. 17:54:29 <fonsinchen> What exactly do you mean by 'class' refactoring? 17:54:59 <Rubidium> that you move the class to the header and unindent everything by 1 tab + add SmallWindow:: to the functions in the .cpp 17:55:25 <Rubidium> usually we do that in one patch, and in the other patch we'd do the remaining codechanges to unify it further 17:56:50 <fonsinchen> well, I need the class declaration in the header, obviously. I can split the patch in two like that, though. 17:57:24 <Rubidium> that'd be favourable; makes it easier to see the actual changes that are being made 18:03:55 <Rubidium> and you might also want to check the TODO you put in smallmap_gui.h 18:07:18 <fonsinchen> OK 18:44:31 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25014 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:46:31 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25015 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:57:43 *** Supercheese has joined #openttd.dev 20:15:14 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25016 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:26:55 <fonsinchen> OK, there you go. The branch is called "cd25016" for now as I want the compile farm to build the hotfix on top of the previous "cd" branch tonight. 20:27:30 <fonsinchen> I've split up the smallmap refactoring into 3 parts and put it at the beginning of the patch queue 20:35:44 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25017 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:37:01 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25018 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:39:11 <Rubidium> a lovely easy to review 71k patch ;) 20:39:59 <fonsinchen> :) 20:47:17 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25019 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:50:21 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25020 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:51:56 <Rubidium> if you would've let cd25016 to compile by the CF, I'd reckon it failed to make binaries 20:52:29 <Rubidium> though I could poke the CF to build cd now 20:52:45 <frosch123> isn't the cd farm failing for months? 20:52:53 <frosch123> i regulary get failures via rss 20:52:57 <fonsinchen> Yes, I've seen 25019 ... I missed that one. 20:53:05 <frosch123> it fails to resolve the repository or something like that 20:53:29 <fonsinchen> It has been working fine for the last couple of weeks after failing a lot before. 20:53:50 <frosch123> ah, indeed, i only get failures via rss, no fixes :) 20:53:51 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25021 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:58:29 <fonsinchen> If you poke the compile farm to build cd now, I'll rename cd25016 to cd after that. I promised that guy on the forums that tonights version will be savegame-compatible ... 20:59:16 <fonsinchen> (and I'll rebase again before that of course) 20:59:42 <Rubidium> did you already merge with the 180/service interval savegame bump? 21:00:33 <fonsinchen> yes 21:00:39 <fonsinchen> not cd, though 21:00:43 <Rubidium> if so, you could keep cd savegame compatible by simply forcing the last 'patch' to emit the right savegame version 21:00:44 <fonsinchen> only cd25016 21:02:24 <fonsinchen> Uhm, actually both have 180 21:06:26 <Rubidium> the CF ought to be done in ~15 minutes 21:06:47 <Rubidium> though it might be busier at this time of day, so it's anybody's guess ;) 21:10:36 <fonsinchen> OK, then I don't start hacking around to preserve savegame compatibility now ... I'll instead rebase again. 21:21:44 <fonsinchen> I've rebased on 25021 and pushed to the usual "cd" branch. 21:22:06 <fonsinchen> Thanks for triggering the CF. 21:25:47 <Rubidium> that new version will build this night 21:29:39 *** LordAro has joined #openttd.dev 21:29:39 *** ChanServ sets mode: +v LordAro 21:38:07 *** FLHerne has joined #openttd.dev 21:38:20 <fonsinchen> good night 21:38:35 <fonsinchen> I'll be back tomorrow around noon 21:38:44 *** fonsinchen has quit IRC 21:55:12 *** FLHerne has quit IRC 22:03:38 *** frosch123 has quit IRC 22:05:17 *** Alberth has left #openttd.dev 22:58:16 *** LordAro has quit IRC