Times are UTC Toggle Colours
08:55:37 *** LordAro has joined #openttdcoop.devzone 09:29:52 * Hirundo is documenting callbacks 09:39:08 <Terkhen> nice :) 09:58:26 <planetmaker> :-) 09:59:43 *** ODM has joined #openttdcoop.devzone 10:35:45 *** FooBar has joined #openttdcoop.devzone 11:41:38 <Hirundo> Some stuff really makes me wonder... 11:42:01 <Hirundo> .. speed units in the station rating callback are the same as those in action0, except for RVs 11:43:21 <Hirundo> It's little details like that that keep bugging you when ploughing through the spec 11:43:56 <planetmaker> :-) 11:55:31 <Brot6> NewGRF Meta Language - Revision 1519:cffe40aff944: Doc #1555: Document callbacks for features 0x0... (Hirundo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/cffe40aff944 12:00:59 <Hirundo> Given that spec_sanity ~ 1 / feature_id, I figured to start at the end ;) 12:03:13 <planetmaker> hm... spec sanity lower for higher feature_ids? ;) 12:05:05 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (Eddi) @ http://dev.openttdcoop.org/issues/2868#change-7082 12:15:44 <Hirundo> it seems to have gotten me insane to the point where I got the formula messed up :) 12:18:11 <Hirundo> Ah well, at least I can hone my skills on the copy-and-modify anti-pattern ;) 12:18:57 <planetmaker> hehe :-) 13:11:15 <Brot6> feed NewGRFs had 15 updates, showing the latest 10 13:11:15 <Brot6> Dutch Tram Set - Revision 70:423b814a4c69: Feature: HTM 4001 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/423b814a4c69 13:11:15 <Brot6> Dutch Tram Set - Revision 71:2b305f73e509: Feature: HTM 821 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/2b305f73e509 13:11:15 <Brot6> Dutch Tram Set - Revision 72:0af281be590a: Feature: HTM 821_751 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/0af281be590a 13:11:16 <Brot6> Dutch Tram Set - Revision 73:161bec015873: Feature: NBM 50 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/161bec015873 13:11:19 <Brot6> Dutch Tram Set - Revision 74:1336d7b86f11: Feature: RET 127 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/1336d7b86f11 13:11:22 <Brot6> Dutch Tram Set - Revision 75:93a2c2012205: Feature: RET 152 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/93a2c2012205 13:11:25 <Brot6> Dutch Tram Set - Revision 76:89b8a9e78c50: Feature: RET 2001 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/89b8a9e78c50 13:11:28 <Brot6> Dutch Tram Set - Revision 77:520b890b29fd: Feature: RET 231 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/520b890b29fd 13:11:31 <Brot6> Dutch Tram Set - Revision 78:abe4a67e89b5: Feature: RET 351 in 2CC (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/abe4a67e89b5 13:11:36 <Brot6> Dutch Tram Set - Revision 79:f0254e396c67: Add: 2CC conversion tools for Photoshop (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/f0254e396c67 13:15:40 <Brot6> Dutch Tram Set - Revision 80:5fcb0657b33a: Update: language and readme: 2CC liveries are now avai... (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/5fcb0657b33a 13:16:17 <planetmaker> overload due to FB ;-) 13:16:43 <Ammler> spamer! 13:18:21 <FooBar> well, it's not there was any conversation going on here :P 13:23:40 <Hirundo> Overloading brot is always a good thing IMO, it's a sign you've been busy 13:23:49 <planetmaker> :-) 13:50:36 * Hirundo ponders cargo subtypes ... probably the most botched concept in NewGRFs 13:58:43 <planetmaker> well... they're "funny" 13:58:59 <planetmaker> one could probably call them "views" in the context of NewObjects for example 14:19:52 <Hirundo> planetmaker: Could you do a quick commit of FS#4690 ? Would save me from documenting Yet Another NFO quirk. :) 14:20:50 <Hirundo> Good thing, NFO quirks don't cause kittens to die 14:22:38 <planetmaker> let's see :-) 14:27:04 <planetmaker> grr... using a different compiler always breaks config and ccache :-( 14:46:21 <planetmaker> hm... where's GetIndustryCallback actually defined... I must be blind 14:57:02 <Hirundo> newgrf_industries.cpp:443 14:57:48 <planetmaker> I just try to understand industry callbacks to actually see where that 1st parameter is used... it's convoluted to say at least :-) 14:58:23 <planetmaker> While it looks 100% correct, I haven't yet quite understood where it is used - which would make me feel much better before commiting it 14:58:39 <Hirundo> it's just variable 10 14:58:51 <Hirundo> used by the grf to do magic stuff 14:59:14 <Hirundo> hmm... I forgot to mention var 0x10 in the FS task 14:59:35 <planetmaker> Yes... well, it's clear that it's var 0x10 as it's the 1st CB variable, yes :-) 15:00:36 <planetmaker> hm... though... actually, yes. It just initializes var 0x10 for that CB, right? 15:01:04 <planetmaker> to a random value 15:02:33 <Hirundo> yes 15:03:05 <Hirundo> around 10 lines above that, the same is done for planting fields 15:05:29 <planetmaker> yes, I see that :-). And for that reason it seems to make 100% sense 15:06:48 <planetmaker> But I haven't yet figured out where the input to GetCallbackResult is actually used in order to return a result ;-) 15:07:15 <planetmaker> But then... that iterates through object::Resolve and can make use of *anything*, I guess, including var 0x10 15:08:00 <Hirundo> Basically SpriteGroup::Resolve runs through the entire varaction2 chain 15:08:25 <planetmaker> good, then I came to the correct conclusion 15:08:57 <planetmaker> and where are param1 and param2 moved to the variables 0x10 and 0x18? 15:09:27 <Hirundo> Reading variables is basically a giant switch statement 15:09:46 <Hirundo> switch(varnum) { case 0x00: ... case0xnn: ... } 15:10:10 <Hirundo> there's a case 0x10: return object.callback_param1 somewhere 15:10:11 <planetmaker> nvm, yes 15:10:18 <planetmaker> :-) 15:10:22 <Hirundo> It might be best though, to wait for frosch 15:10:37 <planetmaker> might be, yes 15:11:02 <Hirundo> He knows most about the industry code, so we're sure we don't commit $badstuff 15:11:08 <planetmaker> But in any case, I'm now convinced :-) 15:11:34 <Hirundo> k good :) 15:11:54 <planetmaker> and I learnt about roughly how this part of the code works ;-) 15:12:35 <Hirundo> hmm... houses have callbacks, but no variables yet 15:24:29 <planetmaker> in NML? 15:44:09 <Hirundo> yes 15:51:15 <Brot6> Central European Train Set - Revision 56:fff689809661: use extra callback info 1 on drawing (need... (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/fff689809661 16:29:49 <Brot6> NewGRF Meta Language - Revision 1520:efd792c1e93c: Doc #1555: Document callbacks for houses and i... (Hirundo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/efd792c1e93c 16:43:13 *** frosch123 has joined #openttdcoop.devzone 17:10:27 <Brot6> nml: update from r1516 to r1520 done - http://bundles.openttdcoop.org/nml/nightlies/r1520 17:19:24 <Brot6> cets: update from r54 to r56 done (442 warnings) - http://bundles.openttdcoop.org/cets/nightlies/r56 17:20:32 <Brot6> dutchtramset: update from r52 to r80 done - http://bundles.openttdcoop.org/dutchtramset/nightlies/r80 17:21:12 <Brot6> Following repos didn't need a nightlies update: ogfx-trains (r245), narvs (r37), bros (r52), ogfx-industries (r121), firs (r2179), sub-landscape (r72), opengfx (r681), ailib-tile (r16), transrapidtrackset (r15), 2cctrainset (r750), ailib-list (r32), opensfx (r97), ttdviewer (r34), worldairlinersset (r672), heqs (r605), openmsx (r97), basecosts (r25), nutracks (r202), nml (r1520), 32bpp-extra (r40), manindu (r7), newgrf_makefile (r305), 17:21:12 <Brot6> ailib-direction (r17), ailib-common (r21), snowlinemod (r49), ai-admiralai (r75), swisstowns (r22), metrotrackset (r56), spanishtowns (r10), frenchtowns (r6), grfpack (r279), ogfx-rv (r107), fish (r655), ogfx-landscape (r70), ttrs (r36), source-test (r2), ogfx-trees (r51), swedishrails (r203), grfcodec (r832), ai-aroai (r39), german-townnames (r34), smts (r19), chips (r143), belarusiantowns (r8), indonesiantowns (r41), ailib-string 17:21:14 <Brot6> (r29), airportsplus (r107), comic-houses (r71) 17:22:31 <Brot6> narvs: compile of r37 still failed (#2789) - http://bundles.openttdcoop.org/narvs/nightlies/ERROR/r37 17:23:09 <Brot6> ogfx-industries: compile of r121 still failed (#2792) - http://bundles.openttdcoop.org/ogfx-industries/nightlies/ERROR/r121 17:35:12 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (oberhuemer) @ http://dev.openttdcoop.org/issues/2868#change-7083 17:37:00 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (oberhuemer) @ http://dev.openttdcoop.org/issues/2868#change-7083 17:38:48 *** andythenorth has joined #openttdcoop.devzone 17:40:24 <Brot6> Following repos rebuilds successful without any difference to earlier nightlies builds: ogfx-trains, firs, sub-landscape, manindu (Diffsize: 1), newgrf_makefile, swisstowns, spanishtowns (Diffsize: 1), frenchtowns, ogfx-rv (Diffsize: 4590), ogfx-landscape (1 warnings) (Diffsize: 5460), source-test (6 warnings), swedishrails, german-townnames, belarusiantowns (Diffsize: 30), indonesiantowns (1 warnings) (Diffsize: 1), airportsplus 17:40:24 <Brot6> (Diffsize: 15915) 17:55:13 *** andythenorth has quit IRC 17:55:48 *** andythenorth has joined #openttdcoop.devzone 18:14:41 <Hirundo> thanks planetmaker 18:15:10 <planetmaker> oh, you're the one who needs thanks extended to :-) 18:15:30 <planetmaker> both, patch and docs :-) 18:19:17 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (oberhuemer) @ http://dev.openttdcoop.org/issues/2868#change-7084 18:19:27 <Brot6> NewGRF Meta Language - Revision 1521:62cc648e43bd: Doc: OpenTTD r22673. (Hirundo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/62cc648e43bd 18:26:38 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (Eddi) @ http://dev.openttdcoop.org/issues/2868#change-7085 18:27:22 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (Eddi) @ http://dev.openttdcoop.org/issues/2868#change-7085 18:37:25 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (oberhuemer) @ http://dev.openttdcoop.org/issues/2868#change-7086 19:08:44 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (Eddi) @ http://dev.openttdcoop.org/issues/2868#change-7087 19:09:54 <Brot6> Dutch Tram Set - Revision 81:0030bc85a116: Feature: RET 127 1931 overhaul updated properties (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/0030bc85a116 19:09:54 <Brot6> Dutch Tram Set - Revision 82:a0b84429a961: Feature: RET 152 1931 overhaul updated properties (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/a0b84429a961 19:09:54 <Brot6> Dutch Tram Set - Revision 83:287c1b23db71: Feature: HTM 21 1929 overhaul updated properties (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/287c1b23db71 19:18:00 *** andythenorth is now known as Guest2795 19:18:01 *** andythenorth has joined #openttdcoop.devzone 19:18:01 *** Guest2795 has quit IRC 19:21:10 <Brot6> Dutch Tram Set - Revision 84:b0a531745fd8: Codechange: simplify HTM 3001 livery change conditions (foobar) @ http://dev.openttdcoop.org/projects/dutchtramset/repository/revisions/b0a531745fd8 19:21:28 *** andythenorth has quit IRC 19:21:29 *** andythenorth has joined #openttdcoop.devzone 19:30:29 <Brot6> Central European Train Set - Code Review #2868: 64 px max length vs. 48 px max length (michi_cc) @ http://dev.openttdcoop.org/issues/2868#change-7088 19:39:32 <Brot6> Central European Train Set - Revision 57:7aa0d40abf8a: add column to tracking table, so it shows ... (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/7aa0d40abf8a 19:48:34 *** andythenorth is now known as Guest2800 19:48:35 *** andythenorth has joined #openttdcoop.devzone 19:48:59 *** Guest2800 has quit IRC 20:10:57 <Brot6> FIRS Industry Replacement Set - Revision 2180:c78529e0ba9c: Change: split yet more industries to ... (andythenorth) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/c78529e0ba9c 20:21:13 <Brot6> FIRS Industry Replacement Set - Revision 2181:79fb1321d30b: Change: split some more industries to... (andythenorth) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/79fb1321d30b 20:28:53 *** frosch123 has quit IRC 20:42:32 *** andythenorth has quit IRC 20:46:29 *** andythenorth has joined #openttdcoop.devzone 21:01:02 <Brot6> Central European Train Set - Revision 58:cdb2b31aa5cb: add column for articulated parts (tender o... (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/cdb2b31aa5cb 21:01:02 <Brot6> Central European Train Set - Revision 59:92696480e013: add tenders to tracking table (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/92696480e013 21:01:02 <Brot6> Central European Train Set - Revision 60:8069555bde07: add callback templates for dummy vehicles (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/8069555bde07 21:01:03 <Brot6> Central European Train Set - Revision 61:339119ea3599: use dummy callbacks (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/339119ea3599 21:02:40 *** FooBar has quit IRC 21:07:38 *** andythenorth has quit IRC 21:33:37 <Brot6> Central European Train Set - Revision 62:fbd9e10da2d6: check uniqueness of ID# (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/fbd9e10da2d6 21:43:54 *** ODM has quit IRC 22:22:57 <Brot6> NewGRF Meta Language - Bug #2869 (New): Sounds documentation... (Hirundo) @ http://dev.openttdcoop.org/issues/2869 23:23:58 <Brot6> Central European Train Set - Revision 63:50e6ec67491c: add column for custom callbacks (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/50e6ec67491c