Times are UTC Toggle Colours
00:44:42 *** TROILUS6 has joined #openttd 00:46:58 *** TROILUS has quit IRC 00:46:58 *** TROILUS6 is now known as TROILUS 02:25:38 *** Wormnest has quit IRC 03:00:06 *** herms has quit IRC 03:03:56 *** herms has joined #openttd 03:30:37 *** D-HUND has joined #openttd 03:34:04 *** debdog has quit IRC 03:35:21 *** D-HUND is now known as debdog 04:15:15 *** TROILUS9 has joined #openttd 04:15:25 *** TROILUS has quit IRC 04:15:25 *** TROILUS9 is now known as TROILUS 04:32:12 *** WormnestAndroid has quit IRC 04:43:02 *** keikoz has joined #openttd 04:51:41 *** Eddi|zuHause has quit IRC 04:56:44 *** keoz has joined #openttd 04:57:18 *** Eddi|zuHause has joined #openttd 05:00:54 *** keikoz has quit IRC 05:11:22 *** keoz has quit IRC 05:12:19 <pickpacket> I need to convert two stations and the really long track between them from electric rail to maglev... there are 80+ trains on that line 05:15:48 *** keoz has joined #openttd 05:17:15 *** WormnestAndroid has joined #openttd 05:19:48 <pickpacket> depots don't show how many trains are currently in them 05:24:09 *** keoz has quit IRC 05:24:50 *** keoz has joined #openttd 05:29:25 *** Flygon has joined #openttd 05:38:37 *** keoz has quit IRC 05:56:51 *** Flygon has quit IRC 05:57:26 *** Flygon has joined #openttd 06:19:44 *** keoz has joined #openttd 06:31:18 *** keikoz1 has joined #openttd 06:32:17 *** keoz has quit IRC 06:41:30 *** keikoz1 has quit IRC 06:42:01 *** keikoz1 has joined #openttd 06:55:08 *** keikoz1 has quit IRC 06:55:18 *** keikoz1 has joined #openttd 07:01:34 *** keikoz2 has joined #openttd 07:01:40 *** keikoz1 has quit IRC 07:50:07 *** keikoz2 has quit IRC 08:10:54 *** keikoz2 has joined #openttd 09:20:12 *** keikoz2 has quit IRC 09:21:21 *** keikoz2 has joined #openttd 09:48:28 *** WormnestAndroid has quit IRC 09:48:33 *** WormnestAndroid has joined #openttd 09:56:38 *** WormnestAndroid has quit IRC 09:56:59 *** WormnestAndroid has joined #openttd 10:01:52 *** keikoz has joined #openttd 10:03:34 *** keikoz2 has quit IRC 10:11:02 *** gelignite has joined #openttd 10:48:01 *** WormnestAndroid has quit IRC 11:24:49 *** WormnestAndroid has joined #openttd 12:09:04 <Xarick> hi 12:12:43 *** keoz has joined #openttd 12:14:34 *** keikoz has quit IRC 12:42:09 <pickpacket> Xarick: o/ 13:35:16 *** TROILUS2 has joined #openttd 13:35:32 *** TROILUS has quit IRC 13:35:33 *** TROILUS2 is now known as TROILUS 13:42:09 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1081209904846606456/screenshot16.png 13:42:09 <Xarick> I'm so happy I was able to rebase 13:42:13 <Xarick> the GUI 13:46:23 <Xarick> took me 20 hours 13:46:27 <Xarick> for a rebase lol 14:11:42 *** WormnestAndroid has quit IRC 14:19:25 <pickpacket> lol 14:19:37 <pickpacket> You have every right to be happy :D 14:19:43 <pickpacket> and it's Friday! 14:48:31 <Eddi|zuHause> wasn't that a meme song like 10 years ago? 14:51:17 <petern> 12 14:51:34 <Eddi|zuHause> well, 2 years didn't happen. 14:52:29 <petern> And she's still only 25... 14:56:26 <Xarick> wow AAAHogEx version 27 is out 14:56:35 <Xarick> mass ships, this AI knows how to terraform 14:57:42 <Xarick> also mass buoys, this guy gonna need more stations just because of buoys alone 14:59:15 <Xarick> the most complete AI to date 15:00:49 <Xarick> and I thought ShipAI was great 15:01:02 <Xarick> this one is just better, it's also impressive at it 15:14:35 <Xarick> looks like ShipAI masses ships faster 15:18:26 *** WormnestAndroid has joined #openttd 15:19:49 <petern> Me: Split the class into smaller files, it'll be better... 15:19:49 <petern> Me later: "11 changed files with 761 additions and 377 deletions" 15:19:58 <petern> 😦 15:21:26 <petern> 40-50 lines of boiler-plate dependency injection for each new class, plus registering each class... Oof. 15:39:49 *** HerzogDeXtEr has joined #openttd 15:56:06 <Rubidium> more code more better, right? 16:15:30 *** TROILUS3 has joined #openttd 16:21:18 *** TROILUS has quit IRC 16:21:19 *** TROILUS3 is now known as TROILUS 16:35:37 *** Alkel_U3 has quit IRC 16:36:17 *** Alkel_U3 has joined #openttd 16:52:00 <Eddi|zuHause> if you get paid per line 16:53:59 <petern> This is more code due to creating an interface and implementing it, instead of calling different methods that all existed in one class. 17:15:48 <LordAro> https://github.blog/2022-06-30-write-better-commits-build-better-projects/ this is an excellent article 17:19:20 <TallTyler> What fortuitous timing, I'll link that in my #10531 review 🙂 17:20:06 <LordAro> :D 17:20:39 <LordAro> on a related note, gitlab cannot automatically rebase on merge. if your branch is behind the target at all, it'll refuse to do anything 17:20:56 <LordAro> this is super irritating, especially if your pipeline is on the order of hours rather than minutes 17:23:06 *** tokai has joined #openttd 17:23:06 *** ChanServ sets mode: +v tokai 17:23:23 <glx[d]> annoying indeed, luckily github nicely supports that 17:23:29 <LordAro> mm 17:23:54 <LordAro> (guess what we've just switched to at work) 17:26:01 <LordAro> although it does (natively) do "merged pipelines" (merge request + main merged together), and "merge trains" (a chain of MRs that are all built together and auto merged in turn, with automatic removal of one from the middle if it interacts poorly) 17:26:06 <LordAro> which is neat 17:26:17 <LordAro> but it only works with a merge commit workflow 17:30:02 *** tokai|noir has quit IRC 17:32:14 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531#pullrequestreview-1324314792 17:51:20 <LordAro> good response TallTyler 17:55:36 *** Wormnest has joined #openttd 17:56:13 *** Borg has joined #openttd 18:08:42 <TallTyler> Thanks 🙂 18:11:47 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #10533: Codechange: Use SQInteger for generic numbers in script API https://github.com/OpenTTD/OpenTTD/pull/10533 18:12:03 <glx[d]> far from being finished 🙂 18:18:33 *** Samu has joined #openttd 18:18:57 <Xarick> how do i split a commit into parts 18:19:21 <LordAro> "carefully" 18:19:59 <LordAro> generally speaking, "git reset HEAD~ --soft" to undo the commit, (then unstage), then select pieces as needed 18:20:57 <Xarick> git add -p does what? the guide isn't too clear 18:20:58 <TallTyler> `git gui` is also quite helpful 18:21:16 <TallTyler> You can amend a previous commit and unstage parts of it, then restage and recommit 18:21:20 <TallTyler> I use it all the time 18:21:34 <petern> You can stage parts of changes with VS Code as well, but git gui is my normal tool too. 18:22:39 <Rubidium> Xarick: step #0 is tagging or making a new (throw away) branch before doing something like that, so you can quickly go back to the previous situation if it failed 18:22:50 <glx[d]> <https://github.com/OpenTTD/OpenTTD/actions/runs/4326125434/jobs/7553165832> at least it's not my code 🙂 18:24:01 <glx[d]> yeah backup before doing anything 18:28:25 *** Samu has quit IRC 18:33:18 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534 18:33:27 <JGR> Even if you make a hash of things you can get back to where you were with got reflog 18:36:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 requested changes for pull request #10494: Add: Use specific error message when vehicle cannot go to station/waypoint https://github.com/OpenTTD/OpenTTD/pull/10494#pullrequestreview-1324392991 18:44:41 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/ec8b2836dfdf04dd978b1dc265eeacf5f9d851bf 18:44:42 <DorpsGek> - Update: Translations from eints (by translators) 18:44:44 <Xarick> error: 18:44:44 <Xarick> You have uncommitted changes in your working tree. Please, commit them 18:44:44 <Xarick> first and then run 'git rebase --continue' again. 18:44:48 <Xarick> I screwed up 18:45:40 <Xarick> How do I create a commit at this point 18:46:19 <glx[d]> with git commit 18:46:31 <Xarick> oh, only command line? 😦 18:46:49 <TallTyler> Git GUI has a user interface you can use for this 18:47:11 <TallTyler> Just type `git gui` into the command line to launch it 18:48:01 <Xarick> doesn't let me commit 18:48:06 <Xarick> says rebase in progress 18:49:25 <Xarick> ah, git gui, never tried this one 18:49:33 <Xarick> yeah this one allowed me to commit 18:55:58 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #10533: Codechange: Use SQInteger for generic numbers in script API https://github.com/OpenTTD/OpenTTD/pull/10533 18:56:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534#pullrequestreview-1324449588 19:02:23 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531 19:02:33 <Xarick> git gui saved me 19:11:14 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531#pullrequestreview-1324466304 19:12:32 <petern> Oh yeah, new Mandalorian to watch. 19:12:37 <petern> And Picard. 19:27:58 <LordAro> ooh yes 19:28:06 *** Flygon has quit IRC 19:51:22 <Xarick> i have more typos to fix 19:51:53 <Xarick> found them while I was rebasing my ai/gs gui branch 19:56:12 *** argoneus has quit IRC 19:56:31 *** Borg has quit IRC 20:13:48 *** TROILUS4 has joined #openttd 20:14:14 *** TROILUS has quit IRC 20:14:15 *** TROILUS4 is now known as TROILUS 20:32:50 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10494: Add: Use specific error message when vehicle cannot go to station/waypoint https://github.com/OpenTTD/OpenTTD/pull/10494 20:34:36 <DorpsGek> [OpenTTD/OpenTTD] ldpl opened pull request #10535: Fix: Restore using founder client name as company manager name https://github.com/OpenTTD/OpenTTD/pull/10535 20:35:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534 20:37:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534#pullrequestreview-1324558933 20:42:35 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534#pullrequestreview-1324564518 20:45:08 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534 20:45:12 <DorpsGek> [OpenTTD/OpenTTD] senseiski commented on issue #10232: [Crash]: Black screen on startup and crash https://github.com/OpenTTD/OpenTTD/issues/10232 20:45:15 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10534: Change: Don't show error when rail/road construction/removal is already done https://github.com/OpenTTD/OpenTTD/pull/10534#pullrequestreview-1324567048 20:45:31 <dP> btw, error location should eventually go into CommandCost as well imo 20:46:13 <TallTyler> As a future addition to the game, or relevant to this PR? 20:46:41 <dP> just a thought for the future 20:46:54 <dP> only relevant to this PR in a way that you can't add location to a constant 20:47:05 <dP> but there already is CMD_ERROR or whatever is it called 20:47:28 <TallTyler> Ah, yes 20:51:42 <Xarick> is a missing tab space a typo or a codechange? 20:51:57 <Xarick> i dunno which commit this change goes to 20:52:55 <TallTyler> Typo, probably 20:53:15 <Xarick> - ShowScriptSettingsWindow((CompanyID)this->selected_slot); 20:53:20 <Xarick> + ShowScriptSettingsWindow(this->selected_slot); 20:53:36 <Xarick> is this also a typo? or goes into simplify code commit? 20:54:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10535: Fix: Restore using founder client name as company manager name https://github.com/OpenTTD/OpenTTD/pull/10535#pullrequestreview-1324579948 20:54:29 <dP> I'd just use Change: 20:55:02 <DorpsGek> [OpenTTD/OpenTTD] senseiski commented on issue #10232: [Crash]: Black screen on startup and crash https://github.com/OpenTTD/OpenTTD/issues/10232 21:04:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10535: Fix: Restore using founder client name as company manager name https://github.com/OpenTTD/OpenTTD/pull/10535 21:05:02 <Xarick> when an expression is continued on the next line, how many tab spaces indents ? 1 or 2? 21:05:12 <Xarick> ah, english 😦 21:06:39 <Xarick> ` new_val = this->clicked_increase ? 21:06:39 <Xarick> std::min(config_item.max_value, new_val + config_item.step_size) : 21:06:39 <Xarick> std::max(config_item.min_value, new_val - config_item.step_size);` 21:07:25 <TallTyler> 2, I think 21:07:38 <Xarick> okay, then I failed on the first commit 21:08:53 <Xarick> and the spacing is really tab, not spaces? 21:09:03 <Xarick> cus i see some weird stuff 21:09:26 <Xarick> IsEditableItem has a mix of tabs and spaces 21:14:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10494: Add: Use specific error message when vehicle cannot go to station/waypoint https://github.com/OpenTTD/OpenTTD/pull/10494#pullrequestreview-1324600523 21:21:22 <Xarick> im terrible at this job 21:21:40 <Xarick> i continue to mix up typos with code changes 21:29:20 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531 21:36:46 *** qwebirc21899 has joined #openttd 21:37:04 <qwebirc21899> hi 21:37:08 <qwebirc21899> any one here? 21:48:54 <andythenorth> no 21:49:10 <andythenorth> wait 21:49:10 <andythenorth> yes 21:50:58 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10519: Feature: Filter engine build menu by name and NewGRF extra text https://github.com/OpenTTD/OpenTTD/pull/10519 21:52:26 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531#pullrequestreview-1324645659 21:54:10 <qwebirc21899> trying to host linux based openttd server 21:54:39 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #10531: Codechange: Cache ScriptConfig for the slot in constructor https://github.com/OpenTTD/OpenTTD/pull/10531#pullrequestreview-1324647482 21:54:50 <qwebirc21899> its running but having issues 21:58:50 <Xarick> CluelessPlus had a crash, a strange one 21:58:59 <Xarick> actually Superlib 40 21:59:50 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1081335150874472559/Unnamed_1973-04-04.png 21:59:50 <Xarick> gonna investigate 22:03:17 <Xarick> doing some math on text strings? weird stuff 22:04:23 <Xarick> local i = startidx == null? string.len() - 1 : startidx; 22:04:46 <Xarick> string is null 22:04:59 <Xarick> so string.len() crashes 22:05:09 <Xarick> why is string null? 22:05:09 *** qwebirc21899 has quit IRC 22:05:56 <Rubidium> because of a bug in your branch? 22:06:02 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10519: Feature: Filter engine build menu by name and NewGRF extra text https://github.com/OpenTTD/OpenTTD/pull/10519#pullrequestreview-1324656999 22:06:48 <TallTyler> #10519 is ready for review! 😄 22:07:11 <Rubidium> at least when the compat_1.2.nut on line 92 is right... 22:07:23 <Xarick> never seen an error coming from superlib itself 22:08:03 <Rubidium> as in master that's only 35 lines for AI or 50 for GS 22:08:23 <Xarick> ah, its probably the Slow valuate 22:11:19 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10494: Add: Use specific error message when vehicle cannot go to station/waypoint https://github.com/OpenTTD/OpenTTD/pull/10494 22:11:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #9807: [Bug]: Error message when trying to order articulated vehicles to non-drive-thru stop is unclear https://github.com/OpenTTD/OpenTTD/issues/9807 22:11:28 <Xarick> main:210 list.Valuate(Connection.IsVehicleToldToUpgrade); 22:11:40 <Xarick> yeah, it's the slow valuate in action 22:13:38 <Xarick> connection:2343 local str = Data.ReadStrFromVehicleName(vehicle_id); 22:13:57 <Xarick> yeah, vehicle_id must have been autoreplaced 22:14:04 <Xarick> so it has another id 22:14:17 <Xarick> this one then becomes invalid 22:14:23 <Xarick> darn 😦 22:14:41 <Xarick> autoreplace is a curse! 22:15:29 <Xarick> vehicle is stopped in depot 22:16:12 <Xarick> so,.. this would probably also crash if using the real Valuate 22:16:17 *** keoz has quit IRC 22:16:22 <Xarick> must investigate further 22:18:02 <TallTyler> dP: Does cmclient already do depot overbuilding and automatic depot orientation? https://github.com/OpenTTD/OpenTTD/pull/9642 22:20:32 <Xarick> ah, no, it's getting a list of all vehicles 22:20:40 <Xarick> not necessarily stopped in depot 22:23:13 <Xarick> so when the list was created, the vehicle_id was valid, then slow valuate took action, and some time after, when iterating that same vehicle, it was already gone, probably autoreplaced because I didn't set up trains for AIs on this game 22:23:30 <Xarick> it was autoreplace all along 22:23:37 <Xarick> combined with slow valuate 22:24:12 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1081341279788605551/Screencast_from_04-03-23_022301.webm 22:24:12 <dP> TallTyler: no overbuilding, and much better approach to automatic orientation 22:24:40 <Xarick> is it drag and drop? 22:24:57 <Xarick> click, then move to the other tile for orientation? 22:25:23 <dP> no, it just automatically snaps to nearest rail 22:25:40 <dP> but you can rotate with mmb if you don't like it 22:27:22 <TallTyler> Your overlay palette recolours are really nice 22:27:46 <Xarick> oh, it's a video 22:27:48 <dP> overbuilding and removal with rails in that pr are nice though 22:27:55 <Xarick> i thought it was an image :9 22:27:58 <TallTyler> I'm still wishing for shaded trees on hillsides but there's so much work to make that happen in vanilla 🫠22:28:10 <dP> TallTyler: yeah, but it's a huge change to do right 22:28:17 <dP> especially with new command system 22:28:34 <dP> I basically had to rewrite it all 22:29:38 <Xarick> really impressive 22:29:42 <dP> and never did proper recolouring in a first place :p 22:30:02 <dP> only 8bpp works well 22:37:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10524: Fix #10522: Link graph line tooltip test for vertical lines https://github.com/OpenTTD/OpenTTD/pull/10524 22:37:25 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #10522: [Bug]: Link graph tooltips: Incorrect handling of exactly vertical link lines https://github.com/OpenTTD/OpenTTD/issues/10522 22:40:41 <JGR> TallTyler: It's not that big really 22:41:19 <JGR> The only tricky bit is extra blitter modes 22:44:06 <Xarick> AdmiralAI has crashes related to indexes in tables 22:44:15 <Xarick> I wonder if i can fix this 22:45:03 <Xarick> local man = ::main_instance._town_managers[town]; 22:45:14 <Xarick> what is ::main_instance? 22:46:23 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1081346863694872627/Unnamed_1974-03-12.png 22:46:36 <Xarick> town 12544 exists 22:46:43 <Xarick> it's a town, how could it not exist? 22:47:43 *** Arastais has joined #openttd 22:47:43 <Arastais> dP: damn, this gives me RCT2 vibes 22:50:25 <Xarick> > ` foreach (town_id, dummy in town_list) { 22:50:25 <Xarick> > this._town_managers.rawset(town_id, TownManager(town_id)); 22:50:25 <Xarick> > }` 22:51:07 <dP> JGR: much better to implement LUTs though as that would allow many other cool features 22:51:16 <Xarick> _town_managers[town] doesn't seem like the correct way to access an item from a table 22:51:31 <Xarick> or maybe it's ::main_instance 22:51:50 <Xarick> any squirrel expert? 22:52:31 <Xarick> ah!!! I know! 22:52:39 <Xarick> it's my AI 22:52:46 <Xarick> my AI creates new towns 22:53:01 <Xarick> AdmiralAI constructed a list of towns at the start, but never updated it 22:53:25 <Xarick> so when it creates a new list and check the index against the index in town_managers, it doesn't exist! 22:53:38 <Xarick> so it crashes 22:53:55 <Xarick> who would have thought creating new towns would crash AdmiralAI 23:06:55 <Xarick> last screenshot of the day 23:07:02 <Xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1081352061096046592/image.png 23:07:09 <Xarick> heading to bed, cyas 23:14:57 *** gelignite has quit IRC 23:34:54 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #10533: Codechange: Use SQInteger for generic numbers in script API https://github.com/OpenTTD/OpenTTD/pull/10533 23:48:36 *** argoneus has joined #openttd 23:49:24 *** argoneus has quit IRC 23:49:28 *** argoneus has joined #openttd 23:49:36 <argoneus> a