Times are UTC Toggle Colours
00:05:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10204: Feature: Add alternative setting for right-click close window option to exclude pinned windows https://github.com/OpenTTD/OpenTTD/pull/10204#pullrequestreview-1531822358 01:39:45 *** Flygon has joined #openttd 02:10:05 *** D-HUND has joined #openttd 02:13:41 *** debdog has quit IRC 03:06:41 <DorpsGek> [OpenTTD/OpenTTD] krysclarke commented on issue #11135: [Crash]: https://github.com/OpenTTD/OpenTTD/issues/11135 04:12:30 *** keikoz has joined #openttd 04:14:43 *** esselfe has quit IRC 04:14:57 *** esselfe_ has joined #openttd 04:16:33 *** ethanabrams has joined #openttd 04:19:20 <ethanabrams> hello 04:21:38 *** ethanabrams has quit IRC 04:31:11 *** justanortherner has joined #openttd 04:31:12 <justanortherner> Goodbye then? 06:59:22 <pickpacket> :) 07:01:52 <andythenorth> o/ 07:05:53 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on pull request #11141: Add: [Script] Game script control of industry production level. https://github.com/OpenTTD/OpenTTD/pull/11141#issuecomment-1637489398 07:12:17 <pickpacket> How does the sale offering for a company going bankrupt work? It happens so rarely in the games I play that I don't remember. Iirc at least one company is offered to buy a competitor that is about to go bankrupt, but I'm not even sure that's true 😆 07:16:11 <andythenorth> GS needs access to industry var 0xB0 07:16:16 <andythenorth> /me looks how to do that 07:17:02 <andythenorth> `case 0xB0: return ClampTo<uint16_t>(this->industry->construction_date - DAYS_TILL_ORIGINAL_BASE_YEAR); // Date when built since 1920 (in days)` 07:17:19 <andythenorth> that 1920 thing is weird, can I just use `this->industry->construction_date`? 😛 07:28:26 <peter1138> Yes, the 1920 thing is to be compatible with NewGRF varactions. 07:28:50 <truebrain> Haven't actually read chat for a while, but was it talked over to have #10204 not dismiss the old setting, and just convert it? We have a few example of that already? 07:29:46 <peter1138> Oh it was mentioned... 07:30:35 <truebrain> I am never a fan of resetting a setting for everyone because one person wanted a new entry in the dropdown 😛 Feels unbalanced 😄 07:30:54 <truebrain> we have solutions, but they take a bit of code .. so I am balancing whether to ask that in this case 07:30:58 <pickpacket> I can't find an explanation of how bankruptcy proceedings work anywhere on the wiki 07:31:20 <pickpacket> or even a page specifically about "Company" in the manual 07:35:36 <andythenorth> ach I've forgotten how to git 🙂 07:35:56 <andythenorth> I need to base patches on master, not 11141 😛 07:35:56 <andythenorth> oops 07:36:16 <truebrain> meh, too bad `full` in settings is not a map, but a list 07:37:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #10204: Feature: Add alternative setting for right-click close window option to exclude pinned windows https://github.com/OpenTTD/OpenTTD/pull/10204#pullrequestreview-1532143028 07:39:38 <truebrain> and just to highlight one thing of my review (CCing talltyler for visibility): we really should stop storing enums as numbers in settings. Please please store them as values 🙂 (so a `full` entry in the settings entry) 07:41:18 <truebrain> After all: `right_click_wnd_close = close-except-sticky` is a lot better than `right_click_wnd_close = 2` 🙂 07:43:00 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #10204: Feature: Add alternative setting for right-click close window option to exclude pinned windows https://github.com/OpenTTD/OpenTTD/pull/10204#pullrequestreview-1532171323 2023-07-17T072023-07-17T23:07:39 *** tokai|noir has joined #openttd 23:07:39 *** ChanServ sets mode: +v tokai|noir 23:14:32 *** tokai has quit IRC 23:37:48 <_glx_> I don't want to count the "forgot to run the script to update msvc projects"