Times are UTC Toggle Colours
00:03:52 *** WormnestAndroid has quit IRC 00:05:30 *** WormnestAndroid has joined #openttd 00:32:24 *** SigHunter has quit IRC 00:32:53 <talltyler> Toyland wins the title game! 😄 00:33:25 *** SigHunter has joined #openttd 00:33:49 <reldred> Disgusting, but hilarious 00:34:08 <talltyler> A well-deserved win, IMO 00:38:14 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #14155: Toyland wins OpenTTD 15.0 Title Game! https://github.com/OpenTTD/OpenTTD/issues/14155 00:44:49 <goddess_ishtar> tbh, Toyland would be way better if it wasn't absolutely eyesearing 00:46:14 <talltyler> The new ground texture helps a lot! 00:46:27 <talltyler> It's at least tolerable now 🙂 01:42:08 *** Wormnest has joined #openttd 01:44:59 <belajalilija> Are you guys actually going to use that map? 01:45:43 <goddess_ishtar> it won the contest, why wouldn't they 01:45:43 <belajalilija> And how many votes did the top 3 get 01:46:01 <belajalilija> No one really likes toyland 01:46:10 <belajalilija> I woulda voted for it 01:46:13 <belajalilija> Because funny 01:46:30 <belajalilija> But i wouldn’t have expected it to have been taken seriously 01:47:04 <belajalilija> Not that that woulda changed my vote 01:47:11 <belajalilija> belajalilija: I forgot to vote 01:47:53 *** Wormnest has quit IRC 01:53:52 <talltyler> I voted for it 🙂 01:57:18 <reldred> I never vote for nothing 01:57:26 <reldred> I’m amused, frankly 01:57:39 <reldred> I can see some people having a whinge but ehhhhh fuck em. 02:22:48 <dwfreed> you can tell them this is what happens when you don't vote 02:22:54 <dwfreed> at least it was Toyland and not Trump 02:24:57 <squirejames> One is a clear mistake, bright garish colours with a terrible economy 02:24:57 <squirejames> The other is Toyland 😛 02:28:52 *** gnu_jj has joined #openttd 02:32:30 *** gnu_jj_ has quit IRC 03:26:08 *** Smedles has quit IRC 03:28:08 *** Smedles has joined #openttd 03:41:19 *** Smedles_ has joined #openttd 03:42:02 *** Smedles has quit IRC 03:47:54 *** WormnestAndroid has quit IRC 03:47:57 *** WormnestAndroid has joined #openttd 03:58:03 *** WormnestAndroid has quit IRC 03:58:06 *** WormnestAndroid has joined #openttd 04:02:29 <zanooda2000> All the other options were pretty sad or boring this time, toyland variant is just at least something unusual. 04:02:29 <zanooda2000> Eh, if only there was a voting option to "keep v14 titlegame"... 04:08:37 *** keikoz has joined #openttd 04:57:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14156: Codechange: remove const char* overloads when there are C++ string overloads https://github.com/OpenTTD/OpenTTD/pull/14156 05:11:40 *** keikoz has quit IRC 05:14:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14147: Codechange: Simplify usage of ResolverObject. https://github.com/OpenTTD/OpenTTD/pull/14147#pullrequestreview-2802009849 05:23:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14157: Codechange: use const for std::string_view where appropriate https://github.com/OpenTTD/OpenTTD/pull/14157 05:26:59 *** Smedles_ has quit IRC 05:27:17 *** Smedles has joined #openttd 06:05:53 <_zephyris> Hehe, better make sure ogfx2 is ready 06:06:05 <_zephyris> It's a good title game! 06:06:26 *** keikoz has joined #openttd 06:12:04 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone opened pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158 06:34:31 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone updated pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158 06:53:14 *** Wolf01 has joined #openttd 07:09:47 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14157: Codechange: use const for std::string_view where appropriate https://github.com/OpenTTD/OpenTTD/pull/14157#issuecomment-2837723012 07:30:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14157: Codechange: use const for std::string_view where appropriate https://github.com/OpenTTD/OpenTTD/pull/14157#issuecomment-2837791928 07:51:42 <peter1138> Ow. 07:51:58 <frosch123> Gh appears a bit broken lately 07:52:21 <frosch123> Now merging does not work 07:56:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14156: Codechange: remove const char* overloads when there are C++ string overloads https://github.com/OpenTTD/OpenTTD/pull/14156#pullrequestreview-2802416021 08:01:19 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14157: Codechange: use const for std::string_view where appropriate https://github.com/OpenTTD/OpenTTD/pull/14157#pullrequestreview-2802428537 08:08:21 <truebrain> Migrating to another platform when? 😛 08:14:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14156: Codechange: remove const char* overloads when there are C++ string overloads https://github.com/OpenTTD/OpenTTD/pull/14156 08:15:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14157: Codechange: use const for std::string_view where appropriate https://github.com/OpenTTD/OpenTTD/pull/14157 08:15:58 <Rubidium> merging works for me 08:30:20 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158#pullrequestreview-2802456062 08:35:15 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14147: Codechange: Simplify usage of ResolverObject. https://github.com/OpenTTD/OpenTTD/pull/14147 08:39:24 <reldred> truebrain: i just got my proxmox cluster at home going, gitlab time 08:39:33 <reldred> or we can run it all on an old mac at andy's house 08:41:55 * peter1138 grumbles about all the string layouters using ucs2/utf16. 08:42:33 <Rubidium> it's the worst of both worlds, right? 08:46:54 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone commented on pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158#issuecomment-2837973884 08:48:33 <peter1138> Harfbuzz can actually take utf-8, utf-16, utf-32, or hb_codepoint_t, and it converts it all internally to hb_codepoint_t. 08:48:58 <peter1138> So it's actually doubly converted from utf-8 to utf-16, then to codepoints. 08:51:14 <peter1138> Icu's bidi stuff is utf-16 though. 08:51:17 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone updated pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158 09:01:43 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone updated pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158 09:05:14 <peter1138> truebrain, still got the old flyspray backups?:D 09:10:17 <peter1138> Hmm, the "why did he use `string?`?" dance... 09:10:59 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148 09:11:00 <peter1138> (Because he also did `#nullable enable` which is both ugly and... maybe useful.) 09:14:42 <xarick> hi 09:17:45 <xarick> I hate my country... "Portugal Ran on 100% Renewable Energy for Six Days", then what the hell happened yesterday? 09:18:05 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148 09:19:07 <xarick> bunch of lying news... how can the entire country be without energy for 12+ hours straigth 09:19:48 <kuhnovic> Time for an openttd-conspiracy channel 09:20:34 <LordAro> i *knew* xarick would reappear with some consipiratorial nonsense 09:20:49 <xarick> in my lifetime it's the second time this type of blackout occurred 09:21:28 <LordAro> but it does seem like someone has significantly fucked up somewhere 09:22:11 <xarick> i guess the other black out we had about ~20 years ago was just in Portugal 09:22:29 <xarick> this one was really special, to have hit spain too 09:23:03 <LordAro> completely collapsing the electrical grid in the entire Iberian peninsula is quite impressive, for sure 09:23:17 <kuhnovic> It just shows that interconnected power grids can (and do) fail spectacularly. And pretty much all of europe's electricity grid is interconnected. 09:23:24 <goddess_ishtar> just realised that I *probably* shouldn't have rebased the commit history because it destroys the authorship data 09:23:25 <goddess_ishtar> welp 09:23:46 <LordAro> goddess_ishtar: author & committer are two separate fields 09:23:56 <LordAro> (some git interfaces are better at displaying this than others) 09:25:36 <peter1138> Also, usually suggestions in github reviews are suggestions you will need to apply yourself and test yourself, rather than just applying them in github. 09:26:49 <peter1138> When I make suggestions I'm not too interested in the authorship side of it. 09:29:07 <peter1138> Probably Portugal could run 100% on renewable energy, when it's planned and the demand is known. Less so when international feeds suddenly get cut off and failsafes (protecting equipment, not protecting supply) activate. 09:29:47 <goddess_ishtar> peter1138: yeah I made a mistake 09:29:59 <goddess_ishtar> applied them in github, then pulled, rebased, and pushed it back as one commit 09:31:06 <goddess_ishtar> it shooooould be fine? 09:35:11 <LordAro> reviewer does not (or should not) care about authorship 09:36:12 <peter1138> Rebase is good and is what we require. But the review is suggesting changes that haven't been tested as a whole. 09:36:35 <peter1138> That's why it doesn't compile now. 09:36:56 <LordAro> like using has_value on a uint 09:37:03 <LordAro> this ain't java :p 09:37:19 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone updated pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158 09:37:35 <goddess_ishtar> peter1138: yeah, in my defense it is currently 5 AM 09:37:42 <goddess_ishtar> but everything should be fixed now 09:39:49 <goddess_ishtar> oh joy, now things are failing in a *different* way 09:39:49 <goddess_ishtar> Error: HttpError: Unknown error: {"data":null,"errors":[{"message":"Something went wrong while executing your query on 2025-04-29T09:37:35+00:00. This may be the result of a timeout, or it could be a GitHub bug. Please include `B841:24FA32:3D0441C:7AA4784:68109DD5` when reporting this issue."}]} 09:40:06 <goddess_ishtar> hey at least this is officially Not My Fault 09:40:21 <peter1138> I also noticed Github has been a bit flakey recently. 09:40:30 <LordAro> github status says that Everything Is Fine 09:47:35 <peter1138> Bah. 09:48:20 <peter1138> `list.Where(x => x.Foo.HasValue).Select(x => x.Foo.Value)` complains in the select that x.Foo might be null. 09:48:54 <pickpacket> is lunch soon? 09:49:14 <goddess_ishtar> it's always lunch somewhere in the world 09:49:22 <pickpacket> yes, but here? 09:51:22 <peter1138> In this channel, no. The designated lunch time starts in about 1.5 hours. (But beware of decimal fractions) 09:53:22 <Rubidium> at 11:30-ish? 09:53:41 <kuhnovic> When the tummy does BRRLLRLRLRLRLRL 09:58:09 <goddess_ishtar> but what about breakfast? 09:58:33 <kuhnovic> Irrelevant 09:59:00 <peter1138> Breakfast is fair game, right up until it's lunch time. 09:59:34 <peter1138> Rubidium, wrong time zone. Please correct yourself. 10:04:14 <peter1138> Ah, apparently there is the `!` operator. 10:04:18 <Rubidium> sorry, but since when is railway time/GMT the wrong time zone in here? :D 10:04:30 <peter1138> `list.Where(x => x.Foo.HasValue).Select(x => x.Foo!.Value)`. 10:04:41 <peter1138> Rubidium, since *we* switched to BST :) 10:08:31 <xarick> okay, so it was 10 hours 10:09:32 <xarick> France recovered quickly 10:16:48 <peter1138> They were probably already marching with guillotinse. 10:16:59 <peter1138> -se+es. 10:37:15 * pickpacket has had lunch now 10:44:55 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159 10:50:33 <pickpacket> MOOOOORRREEEEE! 11:11:48 <peter1138> Have you ever? 11:15:48 <pickpacket> peter1138: me? Have I ever what? 11:18:14 <peter1138> Ever felt like this? 11:24:29 <pickpacket> peter1138: like I feel now? Content? Yeah, most of the time 11:27:39 *** WormnestAndroid has quit IRC 11:27:43 *** WormnestAndroid has joined #openttd 11:28:52 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159#pullrequestreview-2803062124 11:31:21 <peter1138> When strange things happen? 11:32:01 <pickpacket> I love it when strange things happen. Unless they're bad 11:37:06 <peter1138> Are you going 'round the twist? 11:37:30 <pickpacket> I feel like there's some reference here that I don't understand 🤔 11:40:18 *** WormnestAndroid has quit IRC 11:40:27 *** WormnestAndroid has joined #openttd 12:07:34 <FLHerne> apparently it's the theme song to a '90s Australian childrens' TV show 12:12:26 <peter1138> Hmm, unit tests failing due to function signatures being changed. In my mind that should be a compilation failure, so I dunno what is going on. 12:15:51 <peter1138> Oh, there's some reflection going on to call private methods from unit tests. 12:17:50 <pickpacket> FLHerne: bloody hell... I think I might have seen that show as a kid 12:18:47 <pickpacket> oh yes, I definitely did 12:19:01 <pickpacket> dubbed to Swedish, of course, but not the theme song 12:22:03 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158#pullrequestreview-2803172539 12:23:11 <Rubidium> hmm... time for pi? 12:39:22 <pickpacket> Rubidium: in this economy? 12:53:32 <Rubidium> well.. what goes 'round comes around :D 13:12:15 *** Flygon has quit IRC 13:36:49 <pickpacket> :D 14:20:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14160: Codechange: Remove usages of sscanf, atoi and atoll. https://github.com/OpenTTD/OpenTTD/pull/14160 14:24:06 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159 14:24:50 <DorpsGek> [OpenTTD/OpenTTD-TTF] zephyris opened pull request #8: Feature: Hebrew Alphabet for OpenTTD Small and SmallCaps https://github.com/OpenTTD/OpenTTD-TTF/pull/8 14:31:11 <Rubidium> frosch123: for fmt::format whack-a-mole, the failing dedicated build is without precompiled headers. So you might want to build locally with that in mind, otherwise it might take a while 14:43:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14160: Codechange: Remove usages of sscanf, atoi and atoll. https://github.com/OpenTTD/OpenTTD/pull/14160#pullrequestreview-2803967672 14:46:54 *** Wormnest has joined #openttd 14:55:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161 14:58:00 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #14160: Codechange: Remove usages of sscanf, atoi and atoll. https://github.com/OpenTTD/OpenTTD/pull/14160#pullrequestreview-2804016483 15:13:49 *** jkj has joined #openttd 15:29:26 *** nielsm has joined #openttd 15:36:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 15:51:41 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14160: Codechange: Remove usages of sscanf, atoi and atoll. https://github.com/OpenTTD/OpenTTD/pull/14160 16:03:34 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159 16:04:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 16:07:51 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, strtod, ... https://github.com/OpenTTD/OpenTTD/pull/14160 16:09:50 <Rubidium> darn it... we're failing builds left and right lately 16:13:14 <zanooda2000> wensimehrp: Yes, _I can_ (and probably will...) but what about those who like the current titlegame, don't like the new variant and, most importantly, don't even know that they can change their titlegame by some clicks and file renaming? 16:14:40 <jfs> suggestion: change the title game filename from .dat to .sav so it becomes easier to user-replace 16:18:27 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161#pullrequestreview-2804271122 16:20:56 <zanooda2000> hmm 16:20:56 <zanooda2000> hmmmmmm... 16:20:56 <zanooda2000> what about additional folder "titlegame**s**", where the player can throw a bunch of saves, and those save will change each other on. 16:20:56 <zanooda2000> some base 16:21:07 <frosch123> Looks like osx has no from_chars for floats 16:21:36 <frosch123> ifdef and keep strtod? 16:22:42 <_glx_> osx and emscriptem 16:22:56 *** gelignite has joined #openttd 16:23:00 <peter1138> Whew, epoxy fumes. 16:23:41 <_glx_> they both have double version based on the error message 16:24:09 <peter1138> If you don't like the title game, just play the game instead. 16:25:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161#pullrequestreview-2804297794 16:27:58 <Rubidium> please don't make it too easy, as they'll likely end up putting savegames with NewGRFs in there and then things don't work the way they expect anymore 16:29:08 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, strtod, ... https://github.com/OpenTTD/OpenTTD/pull/14160 16:29:31 <frosch123> Removing that commit for now 16:29:56 <_glx_> looks like osx and emscripten tried to use integer version for floats 16:30:53 <_glx_> maybe need to explicitely pass `fmt` 16:31:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 16:32:05 <frosch123> _glx_: Stackoverflow says not implemented in libc++ 16:38:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162#pullrequestreview-2804319347 16:40:09 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 16:43:27 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161#pullrequestreview-2804340255 16:46:16 <Rubidium> cppreference says that Clang libc++ 20 has float support (except long double), but nothing for Apple's one. Not that it matters much 16:49:46 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160 16:51:47 <frosch123> The ci said clang 15 iirc 16:53:02 <tabytac> Rubidium: the solution is very obviously to just flip the switch that says "disable newGRFs on title screen". i know it must exist and would have absolutely no repercussions at all. 16:54:42 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 17:00:00 <DorpsGek> [OpenTTD/OpenTTD] Rau771 started discussion #14163: Suggestion: make titlegames more customisable https://github.com/OpenTTD/OpenTTD/discussions/14163 17:05:34 <xarick> title game already ended? 17:05:41 <xarick> i didn't vote 😦 17:11:17 <_glx_> frosch123: it says 16 for osx 17:12:15 <frosch123> 16 < 20 17:12:38 <frosch123> I'll keep the diff for 2 years 17:21:23 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1366826716697329796/image.png?ex=68125c13&is=68110a93&hm=09c0d07f1a81e4c861a1e7c692f96a85494f56a509fc80db3733f7cebeadd8ec& 17:21:24 <_glx_> seems to still be unsupported 17:21:50 <_glx_> even if appleclang has std::from_chars since 10.0.0 17:22:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159#pullrequestreview-2804435741 17:24:33 <_glx_> tooltip system on compiler support page is so unclear 17:25:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 17:32:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148#pullrequestreview-2804463692 17:33:24 <zanooda2000> tabytac: especially when it works with just another hidden/obscure feature – static newgrfs 17:33:57 <_glx_> static newgrfs don't affect the game 17:36:03 <DorpsGek> [OpenTTD/OpenTTD] frosch123 dismissed a review for pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159#pullrequestreview-2804435741 17:36:06 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159 17:37:00 <zanooda2000> _glx_: hmm, that is, you can use titlegame with newgrfs without static newgrfs? 17:37:00 <zanooda2000> as I remember, that didn't work a few years ago 17:37:21 <frosch123> That pr included a commit from some discarded work... 17:37:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159#pullrequestreview-2804476554 17:38:44 <belajalilija> *why* can’t the title screen have grfs? It is just a save game and the grfs are loaded before the title screen right? 17:38:46 <_glx_> zanooda2000: no, static newgrf are applied to title game, like they are applied to other games, because they don't affect how the game runs 17:48:12 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148 17:49:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148#pullrequestreview-2804502022 17:49:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160#pullrequestreview-2804502830 17:49:32 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160#pullrequestreview-2804503235 17:50:43 <frosch123> belajalilija: You can see the title game while newgrf are scanned 17:51:27 <frosch123> Even static newgrf are not present yet at that point 17:52:03 <frosch123> The title game is updated with static grfs, when the scan is done 17:52:39 <belajalilija> Ahh fair 17:56:21 *** Wormnest has quit IRC 18:03:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148#pullrequestreview-2804535026 18:13:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160#pullrequestreview-2804557696 18:15:00 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160 18:17:28 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158#pullrequestreview-2804573752 18:19:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161 18:25:33 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161#pullrequestreview-2804599556 18:26:26 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14159: Codechange: Use more fmt::format. https://github.com/OpenTTD/OpenTTD/pull/14159 18:27:51 *** WormnestAndroid has quit IRC 18:28:04 *** WormnestAndroid has joined #openttd 18:35:50 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14148: Codechange: Do not use a mutable global to return calculated VarAction2 results. https://github.com/OpenTTD/OpenTTD/pull/14148 18:48:14 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14149: Add: [NewGRF] Add explicit (Var)Action2 results for "callback failed" and "calculated result". https://github.com/OpenTTD/OpenTTD/pull/14149 18:52:32 *** WormnestAndroid has quit IRC 18:55:23 *** WormnestAndroid has joined #openttd 19:02:39 *** WormnestAndroid has quit IRC 19:04:55 *** WormnestAndroid has joined #openttd 19:08:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 19:09:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14161: Codechange: remove char* from base driver code https://github.com/OpenTTD/OpenTTD/pull/14161 19:21:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 19:23:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 19:24:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 19:25:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 reopened pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 19:25:27 <Rubidium> why did GH auto-close that PR?!? 19:27:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 19:34:24 <LordAro> peter1138: good out there, huh? 19:34:46 <andythenorth> Sunny 19:35:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 19:38:02 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164#pullrequestreview-2804785995 19:38:46 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162#pullrequestreview-2804789290 20:13:17 <peter1138> Quite nice. 20:13:47 <peter1138> Easy ride for me, helping a lapsed cyclist get out. 20:15:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14162: Codechange: return std::string_view for Textbuf::GetText() https://github.com/OpenTTD/OpenTTD/pull/14162 20:22:46 <peter1138> Filesystem strings should really be using std::filesystem::path everywhere. 20:23:02 <peter1138> But I kinda gave up on that when it broke compilation in something completely different. 20:33:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14164: Codechange: use std::string_view for FS2OTTD and OTTD2FS https://github.com/OpenTTD/OpenTTD/pull/14164 20:37:26 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1366876050369413221/image.png?ex=68128a05&is=68113885&hm=4d6390d1a93de5d26bec9485f3a5ec96a5ed9da52dd3de3d575e2b8b0d18957d& 20:37:26 <xarick> wow... this actually happened 20:37:42 <xarick> and cancelled the whole route 20:43:42 <xarick> something weird happening with the finances window and loan 20:44:10 <xarick> it is not reflecting the amount the ai have loaned 20:44:25 <xarick> it's not dirtying 20:45:31 *** akimoto has joined #openttd 20:45:52 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1366878175098966096/image.png?ex=68128c00&is=68113a80&hm=6ced9495d35ed6633c76bdde43060cdc5b91686b672ec43ec94afbaa59c0917b& 20:45:52 <xarick> this does not add up 20:46:13 <xarick> 258508 + 1492 = 260000 20:48:58 <xarick> oh, I have to click the window title to update the loan 20:49:01 <xarick> bug 20:53:43 <xarick> i suspect 14111 20:54:34 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14165: Codechange: replace char* with C++ style strings https://github.com/OpenTTD/OpenTTD/pull/14165 20:55:47 *** akimoto has quit IRC 21:01:11 <peter1138[d]> Oh, most of the time loan isn't updated. 21:03:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14165: Codechange: replace char* with C++ style strings https://github.com/OpenTTD/OpenTTD/pull/14165 21:04:34 <xarick> seems to update based on some kind of timer 21:04:45 <xarick> or until i start dragging the window 21:05:02 *** WormnestAndroid has quit IRC 21:05:12 *** WormnestAndroid has joined #openttd 21:06:36 <peter1138[d]> Well that will trigger a redraw, yes. 21:10:00 *** gelignite has quit IRC 21:11:39 <xarick> I would post a savegame but it's a 4k map 21:11:50 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened issue #14166: [Bug]: Loan in the Finances widnow is not updating in real time https://github.com/OpenTTD/OpenTTD/issues/14166 21:21:20 *** nielsm has quit IRC 21:25:29 *** keikoz has quit IRC 21:29:20 *** tokai|noir has joined #openttd 21:29:20 *** ChanServ sets mode: +v tokai|noir 21:36:19 *** tokai has quit IRC 21:37:47 <peter1138> I'm actually kinda surprised at how well updating only the specific widgets it does update avoids updating the loan value. 21:53:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14167: Fix 261e09a549: Compilation failure with Fluidsynth enabled. https://github.com/OpenTTD/OpenTTD/pull/14167 22:00:35 <peter1138> Hmm, I guess a few music basesets are doing their version number incorrectly. 22:04:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14160: Codechange: Remove usages of sscanf, atoi, strtol, strtoul, ... https://github.com/OpenTTD/OpenTTD/pull/14160#issuecomment-2840345652 22:06:23 <frosch123> At least no negative versions 22:09:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14168: Fix #14166, dfd9fbf873: Loan was no longer invalidated when refreshing finance window. https://github.com/OpenTTD/OpenTTD/pull/14168 22:13:38 <peter1138> Also of note, the filename of the baseset isn't displayed until I enable grf (?) debugging. 22:19:56 *** Flygon has joined #openttd 22:20:57 <xarick> max loan changes frequently with inflation 22:22:45 <peter1138> That isn't exactly frequently. 22:23:17 <peter1138> The other values can change 100s of times in 1 game tick. 22:29:39 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14168: Fix #14166, dfd9fbf873: Loan was no longer invalidated when refreshing finance window. https://github.com/OpenTTD/OpenTTD/pull/14168#pullrequestreview-2805214295 22:51:23 <DorpsGek> [OpenTTD/OpenTTD] Iris-Persephone commented on pull request #14158: Add: "Many random towns" button in scenario editor now prompts for the number of towns, with defaults based on the current new game settings https://github.com/OpenTTD/OpenTTD/pull/14158#pullrequestreview-2805271139 22:52:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14168: Fix #14166, dfd9fbf873: Loan was no longer invalidated when refreshing finance window. https://github.com/OpenTTD/OpenTTD/pull/14168 22:52:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14166: [Bug]: Loan in the Finances widnow is not updating in real time https://github.com/OpenTTD/OpenTTD/issues/14166 22:52:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14154: Codechange: Use result of .find() instead of looking up multiple times. https://github.com/OpenTTD/OpenTTD/pull/14154 22:53:26 *** D-HUND has joined #openttd 22:53:34 *** Wolf01 has quit IRC 22:56:49 *** debdog has quit IRC 23:57:34 *** WormnestAndroid has quit IRC 23:57:49 *** WormnestAndroid has joined #openttd