Times are UTC Toggle Colours
00:49:09 *** Gustavo6046 has quit IRC 00:52:48 *** Gustavo6046 has joined #openttd 00:54:07 *** Smedles_ has joined #openttd 00:55:11 *** Smedles has quit IRC 01:19:18 *** Wormnest has joined #openttd 01:26:11 *** Smedles_ has quit IRC 01:38:50 *** Smedles has joined #openttd 01:41:02 *** gelignite_ has joined #openttd 01:48:21 *** gelignite has quit IRC 01:53:56 *** Flygon has joined #openttd 02:07:46 *** glx has quit IRC 02:14:11 *** D-HUND has joined #openttd 02:17:36 *** debdog has quit IRC 02:28:54 <DorpsGek_III> [OpenTTD/nml] jrook1445 opened issue #120: nml 0.5.0 - industries transported_last_month_pct variable not in range 0..100 https://git.io/Jfc3f 02:37:08 <DorpsGek_III> [OpenTTD/nml] jrook1445 opened issue #121: nml 0.5.0 - unable to STORE_PERM(x, y) where y > 15 https://git.io/Jfc34 02:40:53 *** Wormnest has quit IRC 02:49:59 *** gelignite_ has quit IRC 02:52:51 *** Smedles has quit IRC 04:01:26 *** k-man has quit IRC 04:04:07 *** mindlesstux66 has joined #openttd 04:05:34 *** mindlesstux6 has quit IRC 04:09:22 *** snail_UES_ has quit IRC 04:09:41 *** snail_UES_ has joined #openttd 04:09:44 *** k-man has joined #openttd 04:51:59 *** sla_ro|master has joined #openttd 04:54:42 *** Foveafoxy has joined #openttd 04:55:18 *** Foveafoxy is now known as Guest24449 06:03:22 *** WormnestAndroid has quit IRC 06:03:35 *** WormnestAndroid has joined #openttd 06:17:54 *** WormnestAndroid has quit IRC 06:18:11 *** WormnestAndroid has joined #openttd 06:24:43 *** Smedles has joined #openttd 07:11:03 *** snail_UES_ has quit IRC 07:11:28 *** snail_UES_ has joined #openttd 07:19:33 *** snail_UES_ has quit IRC 07:19:58 *** Wolf01 has joined #openttd 07:20:57 *** Guest24449 has left #openttd 07:20:59 *** Guest24449 has joined #openttd 07:48:23 *** andythenorth has joined #openttd 08:06:46 <andythenorth> o/ 08:08:21 *** nielsm has joined #openttd 08:12:11 *** snail_UES_ has joined #openttd 08:12:56 <andythenorth> couple of nice nml bug reports 08:13:00 <andythenorth> with repros 08:20:14 *** snail_UES_ has quit IRC 08:20:43 *** iSoSyS has joined #openttd 08:38:31 *** JiMMY424 has joined #openttd 08:40:14 *** JiMMY424 has quit IRC 08:45:23 *** supermop_Home has quit IRC 09:05:40 *** cHawk has joined #openttd 09:06:03 *** Samu has joined #openttd 09:08:28 *** snail_UES_ has joined #openttd 09:09:07 <Samu> hello 09:09:48 *** gnu_jj has quit IRC 09:17:53 *** orudge has quit IRC 09:19:08 *** orudge has joined #openttd 09:19:32 *** matt21347 has joined #openttd 09:23:25 <FLHerne> andythenorth: Incidentally, your usage of "deprecated" continues to bug me 09:23:54 <FLHerne> "Deprecated" specifically *doesn't* mean "removed" 09:26:48 <nielsm> yes, it means "still exists but discouraged from use in new development" 09:27:14 <nielsm> (and encouraged to migrate existing systems off it) 09:27:50 <FLHerne> Right 09:28:13 <FLHerne> But all the nml commit messages say "deprecate *whatever industry stuff*" while deleting it all 09:30:49 <FLHerne> What's consistency? 09:30:52 <FLHerne> We have: 09:30:56 <FLHerne> - percent_transported_passengers 09:31:10 <FLHerne> - last_month_transported 09:31:17 <FLHerne> - transported_last_month_pct 09:31:36 <FLHerne> (to be fair, that predates the new industry spec) 09:36:13 <rudolfs[m]> Speaking of "deprecated", yesterday I ran into nml bug, where it called a python function, that was previously deprecated, but now removed 09:36:17 <rudolfs[m]> https://bugs.launchpad.net/debian/+source/nml/+bug/1877433 09:40:50 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #122: Fix #120: Value range of transported_last_month_pct should be 0..100. https://git.io/Jfcux 09:41:16 <FLHerne> rudolfs[m]: That was fixed in 0.5.0 09:48:49 <rudolfs[m]> That's great! But I think it's still a good idea to take deprecations seriously, since packaged software tends to not be updated as frequently. 09:58:43 <FLHerne> rudolfs[m]: Your friendly Debian packager is blathijs, but AIUI he's waiting for 0.5.1 because of all the bugs :P 10:00:10 <rudolfs[m]> :D 10:02:14 *** gnu_jj has joined #openttd 10:02:47 <andythenorth> FLHerne we could just change it to removed 10:02:54 <andythenorth> it's no skin off my nose 10:03:25 <andythenorth> nml wiki says 'removed' where appropriate 10:05:45 <andythenorth> FLHerne where are you finding 'deprecated'? I'll change them, unless its commit 10:06:24 <blathijs> FLHerne: Yup, the release tarball got a bit messed up with 0.5.0, so I'm indeed waiting for 0.5.1 which should make everything better :-) 10:06:43 <FLHerne> andythenorth: Commits mostly 10:07:03 <FLHerne> I think it was in an an earlier draft of the changelog, but gone in the final one 10:07:32 <FLHerne> (rewriting the git history of 0.5.0 just to fix that might be overkill :P) 10:07:43 <andythenorth> probably, but it's a note for future 10:07:48 <andythenorth> I agree on the terminology 10:07:59 <FLHerne> OTOH, you could squash all the random bugfixes and look more competent ;-) 10:08:20 <andythenorth> we seem to be holding open 0.5.1 for a while 10:08:25 <andythenorth> despite it being broken in prod 10:08:50 <andythenorth> if this was a work project I'd have released the early fixes 10:09:10 <andythenorth> on the basis that broken in prod is bad 10:09:25 <FLHerne> There are more fixes, though 10:09:25 <andythenorth> and now we have more emerging bugs, so we'll probably hold 0.5.1 for longer? 10:09:49 <andythenorth> I do find OpenTTD very confusing sometimes :) 10:09:51 <andythenorth> but nvm 10:10:34 <LordAro> depends how easy they are to fix 10:11:11 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #119: Add: Builtin functions `roadtype()` and `tramtype()`. https://git.io/Jfcgt 10:11:17 <andythenorth> I haven't looked yet, I need a day from my actual software day job :) 10:11:22 <FLHerne> The latest ones look trivial, I've just posted a PR for the first one 10:11:22 <andythenorth> I"m just hanging out for the chat 10:11:30 <andythenorth> day off * 10:11:41 * andythenorth hasn't had a day off since Jan 2nd except public holidays 10:12:08 <FLHerne> I think #119 should go to stable? It's basically a fix for the NRT support 10:12:37 <FLHerne> (originally it was prefixed Fix:, but Yexo thought "Fix: Add..." was silly) 10:12:52 <andythenorth> does it have docs and some sort of test? :) 10:13:09 <FLHerne> I'll edit the wiki when it's merged 10:13:13 <FLHerne> Not tested 10:13:21 <FLHerne> I can add a test 10:13:29 <andythenorth> I think that helps 10:13:35 <DorpsGek_III> [OpenTTD/nml] LordAro merged pull request #119: Add: Builtin functions `roadtype()` and `tramtype()`. https://git.io/JfcTE 10:13:38 <andythenorth> either test, or in examples 10:13:46 <andythenorth> wiki is very appreciated 10:14:13 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #122: Fix #120: Value range of transported_last_month_pct should be 0..100. https://git.io/JfcgG 10:14:28 <FLHerne> There are no roadtype tests in regression/ at all? 10:14:38 <andythenorth> I doubt it, my patch was clown shoes 10:14:43 <FLHerne> That makes it less easy to add to one :P 10:15:31 <DorpsGek_III> [OpenTTD/nml] LordAro dismissed a review for pull request #115: Fix #112: use setuptools_scm to determine version https://git.io/Jf3E2 10:16:41 <FLHerne> LordAro: 255 * 101 / 256 is 100 10:17:07 <LordAro> FLHerne: i figured it was something like that 10:17:17 <LordAro> i have a maths degree, don't y'know 10:17:23 <LordAro> long since forgotten everything 10:17:28 <FLHerne> The natural way would be 255/256 * 100, but you'd get 0 because integers :P 10:17:35 <LordAro> aye 10:18:30 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #122: Fix #120: Value range of transported_last_month_pct should be 0..100. https://git.io/Jfcux 10:18:31 <DorpsGek_III> [OpenTTD/nml] FLHerne closed issue #120: nml 0.5.0 - industries transported_last_month_pct variable not in range 0..100 https://git.io/Jfc3f 10:19:05 <LordAro> i think we should just get on and release 0.5.1 10:19:10 <LordAro> #112 can wait 10:19:15 <LordAro> (apparently) 10:19:38 <FLHerne> I think I'll just merge 119, writing regression tests for all of NRT is out of scope 10:19:59 <LordAro> FLHerne: too late :p 10:21:18 <FLHerne> Hm, I could add it to the examples 10:21:33 <FLHerne> The examples aren't actually tested, are they? 10:21:50 <FLHerne> Perhaps they should be, at least that they build 10:22:14 <andythenorth> I think they should be 10:22:21 <andythenorth> I appreciate they're not conventional unit tests 10:22:33 <andythenorth> but they are a form of tested documentation 10:22:41 <andythenorth> and as we're sticking to the wiki (afaict) 10:22:48 <andythenorth> it's impossible to include docs with the PR 10:42:56 *** Guest24449 has quit IRC 10:47:17 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #123: Docs: Add a use of `roadtype()` to the examples. https://git.io/Jfc2O 10:47:42 <FLHerne> (is that the right prefix? idk) 11:02:59 <andythenorth> Doc: 11:03:12 <andythenorth> catches me every time, I use Docs: elsewhere 11:05:15 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #123: Docs: Add a use of `roadtype()` to the examples. https://git.io/Jfc2O 11:06:09 <andythenorth> hmm 11:06:16 <andythenorth> nobody makes black LEDs? 11:10:47 <FLHerne> IR ones could be? 11:11:31 <rudolfs[m]> You mean just diodes? 11:12:02 <FLHerne> Diodes don't emit light 11:12:19 <Wolf01> I need a negative light one 11:13:07 <FLHerne> Solar panel? 11:13:21 <Wolf01> Nope, I need to make darker 11:15:40 <milek7> you just need portable black hole 11:16:01 <Wolf01> That sucks... literally :P 11:22:37 <Samu> custom graph aystar! https://github.com/SamuXarick/Canal-Pathfinder/tree/Graph.AyStar-customized-for-speed/library/Pathfinder.Canal 11:22:52 <Samu> isn't yexo around? 11:25:11 <andythenorth> isn't that self explanatory Samu? :) 11:27:02 *** APTX has quit IRC 11:36:54 *** APTX has joined #openttd 12:10:49 *** glx has joined #openttd 12:10:49 *** ChanServ sets mode: +v glx 12:17:52 *** Foveafoxy has joined #openttd 12:18:29 *** Foveafoxy is now known as Guest24477 12:44:34 <DorpsGek_III> [OpenTTD/nml] glx22 opened pull request #124: Fix #121, da57fb5: check StorageOp register range only once https://git.io/JfcK8 12:56:10 *** iSoSyS has quit IRC 12:56:18 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfZi5 12:57:06 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfcK7 13:30:07 *** andythenorth_ has joined #openttd 13:30:59 <FLHerne> Hm 13:32:34 <FLHerne> I set up `make test` to test the examples 13:33:10 <FLHerne> But now the tests fail :P 13:33:56 <andythenorth_> that's...information :) 13:36:36 *** andythenorth has quit IRC 14:07:07 <Samu> :( 14:14:35 *** Wormnest has joined #openttd 14:26:27 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #125: Codechange: Build examples in regression testing https://git.io/JfcXX 14:28:53 *** Foveafoxy has joined #openttd 14:28:58 <FLHerne> I'm puzzled 14:29:12 <FLHerne> At least some of the ANIM warnings seem to be bogus, or at least the pixel locations 14:29:31 *** Foveafoxy is now known as Guest24490 14:32:40 <glx> example_industry builds fine here 14:33:50 <FLHerne> glx: In that particular case, the --nml output is bogus, and the test-build of that fails 14:34:10 <FLHerne> If you remove that, something else crashes 14:34:21 * FLHerne tries to fix things 14:35:08 *** Exec has quit IRC 14:35:10 <glx> oh outdated vars 14:35:53 *** Guest24477 has quit IRC 14:36:05 *** Exec has joined #openttd 14:38:51 <FLHerne> andythenorth_: You wrote that example - are test_produce_2 and _3 supposed to do anything? 14:38:57 <FLHerne> Or can I just delete them? 14:40:06 <glx> hmm unreferenced stuff should not be in --nml output 14:40:10 <FLHerne> (and what are the STORE_TEMPs for? nothing reads them) 14:40:12 <glx> that's the bug 14:40:28 <nielsm> I probably wrote that example 14:40:47 <nielsm> and I don't remember why it'd be incomplete like that 14:41:01 <FLHerne> nielsm: Ok, andy's down as the commit author 14:43:06 *** iSoSyS has joined #openttd 14:43:14 <nielsm> looking at it, I think that produce might just be wrong 14:43:34 <nielsm> it will loop producing infinite STEL 14:44:21 <nielsm> (is there a requirement the examples are meaningful when loaded in the game?) 14:46:13 <FLHerne> I think so, otherwise they're not sensible examples? 14:46:58 <FLHerne> An example of how to produce infinite cargo is useful to no-one and misleads everyone else? 14:47:10 <nielsm> yeah 14:47:18 <FLHerne> I agree, that seems to be what it does 14:47:23 <nielsm> I should rewrite that 14:47:35 <glx> Produce2 __str__ is wrong anyway 14:48:24 <glx> or it's some __str__ in the elements 14:52:24 <glx> ha no, it's Produce2 __str__, it doesn't handle lists properly 14:55:55 <FLHerne> Why does Produce not-2 still exist? 14:56:09 <FLHerne> I don't think it's used anywhere 14:56:28 <FLHerne> nielsm: ^ is that left over from when you supported the old syntax too? 14:57:58 <nielsm> I think so yes 14:58:27 <glx> looks like 0.4 syntax yes 15:01:50 <andythenorth_> FLHerne where am I looking for test_produce_2 and test_produce_3? 15:02:05 <andythenorth_> I don't see them in examples/industry/example_industry.nml 15:03:32 <andythenorth_> I've considered writing a full set of examples 15:03:36 <andythenorth_> as a reference implementation 15:03:44 <andythenorth_> but I spend so much time on newgrf tools now 15:03:50 <andythenorth_> I can't write any of my own newgrfs 15:03:59 <andythenorth_> there's a probably a catchy name for that :P 15:05:16 <nielsm> https://github.com/OpenTTD/nml/blob/master/examples/industry/example_industry.nml#L40-L42 15:07:50 <andythenorth_> oh no _ 15:07:52 <andythenorth_> ok :) 15:09:47 <FLHerne> Sorry 15:10:21 <FLHerne> glx: Are you still looking at the Produce2 printing, or should I? 15:10:23 <glx> I fixed Produce2.__str__ 15:10:27 <FLHerne> Oh, ok :-) 15:10:35 <glx> let me PR 15:10:51 *** Flygon has quit IRC 15:11:37 * FLHerne tries to fix the tracktypetable.__str__ crash 15:13:31 <DorpsGek_III> [OpenTTD/nml] glx22 opened pull request #126: Fix: Produce2 printing https://git.io/JfcD6 15:13:43 *** cHawk has quit IRC 15:14:16 <glx> and I think Produce2 should be renamed Produce, and the old one can go 15:16:18 <glx> I could add the cleanup in the PR 15:17:19 <FLHerne> +1 15:18:49 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened pull request #8124: Fix f538179, #8119: Update docking tile area when placing a diagonal rail next to a dock end https://git.io/Jfcyk 15:20:23 <andythenorth_> wfm 15:20:40 <Samu> why's the commit checker complaining ? :( 15:21:11 <glx> commit checker should tell you where the error is 15:21:39 *** supermop_Home has joined #openttd 15:22:09 <glx> oh start with issue number 15:22:33 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #8124: Fix f538179, #8119: Update docking tile area when placing a diagonal rail next to a dock end https://git.io/Jfcyk 15:22:37 <Samu> ok, done 15:22:51 <andythenorth_> chemicals industry chains are nuts https://www.uop.com/wp-content/uploads/2012/12/Olefins-Olefins_Value_Chain-900x400_flows.jpg 15:22:54 <andythenorth_> that's just a tiny part 15:23:12 <andythenorth_> https://www.researchgate.net/profile/Galina_Xanthopoulou2/publication/236166915/figure/fig1/AS:393544490602497@1470839726136/Value-chain-of-Oil-Gas-hydrocarbons.png 15:24:11 <FLHerne> andythenorth_: You might like https://www.reddit.com/r/openttd/comments/gfqas3/can_someone_send_the_industry_chain_for_all/ 15:24:17 <andythenorth_> I did :) 15:24:18 <FLHerne> (if you've not seen it) 15:24:21 <FLHerne> Ok, ok 15:24:30 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #126: Fix: Produce2 printing https://git.io/JfcD6 15:24:32 <andythenorth_> it also disturbs me they had FIRS 1.4.5 on their server for so long 15:24:34 <FLHerne> Those online docs are great, and also FIRS is great 15:24:39 <andythenorth_> I nearly joined reddit to ask them to stop 15:24:51 <andythenorth_> this one is pretty good https://www.ccmintel.com/images/value-chain-img.png 15:25:38 <andythenorth_> should I do natural gas as a cargo, or have a gas cracker that acts like a primary? 15:25:57 <andythenorth_> i.e. it produces the downstream products of natural gas with no supply 15:37:36 *** snail_UES_ is now known as Guest24498 15:37:36 *** snail_UES_ has joined #openttd 15:39:13 *** Wormnest has quit IRC 15:50:59 <FLHerne> I kind of liked FIRS 1 15:51:06 <FLHerne> The clustered industries were nice 15:56:18 <andythenorth_> I remember those 15:56:39 <andythenorth_> if cargo was evenly distributed to industries from stations, I might have kept them 15:56:49 <andythenorth_> but the mechanic was broken, not in a good way 16:08:30 *** gelignite has joined #openttd 16:12:25 <glx> FLHerne: tracktypetable.debug_print() is wrong too, but at least it doesn't crash 16:15:50 <supermop_Home> andythenorth_ but little RVs to deliver supplies were cute 16:22:31 *** Wormnest has joined #openttd 16:24:20 <FLHerne> glx: Meh, I think debug_print is pointless and redundant anyway, but I'll fix it :P 16:26:37 <andythenorth_> too many times they can't fit supermop_Home 16:26:41 <andythenorth_> overlapping delivery stations 16:26:45 <andythenorth_> I could probably have tuned that 16:26:51 <andythenorth_> but it was frustrating 16:28:06 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #127: Fix: tracktypetable printing https://git.io/JfcHF 16:28:29 <FLHerne> Oops 16:29:44 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #127: Fix: tracktypetable printing https://git.io/JfcHF 16:33:40 <DorpsGek_III> [OpenTTD/nml] FLHerne approved pull request #126: Fix: Produce2 printing https://git.io/JfcQc 16:38:31 <DorpsGek_III> [OpenTTD/nml] glx22 approved pull request #127: Fix: tracktypetable printing https://git.io/JfcQV 16:39:27 <DorpsGek_III> [OpenTTD/nml] glx22 merged pull request #126: Fix: Produce2 printing https://git.io/JfcD6 16:40:03 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #127: Fix: tracktypetable printing https://git.io/JfcHF 16:42:59 * FLHerne checks the various ANIM warnings 16:55:08 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #128: Fix: ANIM warnings in examples https://git.io/Jfc7r 16:55:39 <FLHerne> (the ones in the object example were actual stray pixels, I think) 16:57:12 <andythenorth_> thanks :) 17:00:09 *** Progman has joined #openttd 17:00:50 <FLHerne> andythenorth_: Can you review it? Then I can merge it and rebase the testing one 17:07:21 <andythenorth_> I am a bit afk sorry :) 17:07:23 <andythenorth_> cooking 17:07:24 <andythenorth_> biab 17:07:37 <FLHerne> Ok 17:13:36 <DorpsGek_III> [OpenTTD/nml] FLHerne approved pull request #124: Fix #121, da57fb5: check StorageOp register range only once https://git.io/Jfc52 17:15:51 *** iSoSyS has quit IRC 17:19:35 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #124: Fix #121, da57fb5: check StorageOp register range only once https://git.io/JfcK8 17:19:36 <DorpsGek_III> [OpenTTD/nml] FLHerne closed issue #121: nml 0.5.0 - unable to STORE_PERM(x, y) where y > 15 https://git.io/Jfc34 17:27:06 <DorpsGek_III> [OpenTTD/nml] glx22 opened pull request #129: Fix: townames debug_print https://git.io/Jfcdq 17:27:38 <FLHerne> glx: Typo in the title 17:28:05 <glx> in commit too :) 17:29:10 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #129: Fix: townames debug_print https://git.io/Jfcdq 17:30:18 *** frosch123 has joined #openttd 17:33:54 <FLHerne> nielsm: I tried the example industry in-game, on first delivery it throws up "'Factory' caused an endless loop in the production callback" as you suspected 17:34:18 <frosch123> is it possible to add a custom text to the "merge" button on github? 17:34:20 <FLHerne> (I was curious if it was going to crash the game) 17:34:33 <frosch123> people keep on forgetting to update the docs when they add stuff to nml 17:34:56 * FLHerne realizes he forgot to update the docs :P 17:36:39 <FLHerne> (fixed) 17:37:23 <frosch123> thanks :) 17:39:36 <andythenorth_> frosch123 that's the main reason I wanted to ditch the wiki 17:39:47 <andythenorth_> I am convinced it's not a good reason 17:39:55 <andythenorth_> does GitHub have custom workflows? 17:40:11 <frosch123> andythenorth_: people also forget to add stuff to the ai/gs changelog in ottd 17:40:18 *** Exec has quit IRC 17:40:40 <andythenorth_> at work we have deployment steps for tickets 17:40:45 <glx> and sometime forget to run the generate scripts 17:40:47 <frosch123> so unless you manage to add an automatic commit check... just putting it into the same repo does not solve it 17:41:00 *** Exec has joined #openttd 17:41:02 <andythenorth_> a ticket can be merged but not deployed, so we have a stage for that 17:41:11 <andythenorth_> I am -1 to lots of workflow, but it has uses 17:56:33 *** tokai has joined #openttd 17:56:33 *** ChanServ sets mode: +v tokai 17:56:51 <andythenorth_> hmm not sure 'workflow' means the same thing in github 17:56:53 * andythenorth_ reading 17:57:19 <andythenorth_> seems to be GH Actions 17:57:45 <frosch123> we can make a PR template with a list of things to remind about 17:58:08 <FLHerne> Can someone just click 'accept' on #128? All it does is add ANIM flags and change two pixels 17:58:10 <andythenorth_> we could make a merge automatically make a new nagging issue to update docs :P 17:58:15 <andythenorth_> FLHerne I will yes 1 min 17:58:33 <FLHerne> Trying to test it, I'm puzzled that the object can't actually built in-game... 17:58:54 <FLHerne> It says "Can't build object... Infrastructure" 17:59:03 *** iSoSyS has joined #openttd 17:59:05 <FLHerne> (same is true before) 17:59:07 <andythenorth_> GH has image diff :) 17:59:13 <andythenorth_> too small to see anything but still nice 18:00:49 <DorpsGek_III> [OpenTTD/nml] frosch123 approved pull request #128: Fix: ANIM warnings in examples https://git.io/JfcFa 18:01:15 *** D-HUND is now known as debdog 18:01:46 <FLHerne> frosch123: Any idea what "Can't build object... <classname>" means? I wondered if INFR was a special-case, but it's the same if I change it 18:02:31 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #128: Fix: ANIM warnings in examples https://git.io/Jfc7r 18:02:41 <frosch123> nml examples often use dummy texts, so <classname> probably means nothing 18:02:49 <frosch123> is there a location check in the nml? 18:03:28 *** tokai|noir has quit IRC 18:03:57 <FLHerne> frosch123: In-game, I mean 18:04:21 <FLHerne> The newgrf compiles fine, but the object it defines can't be built 18:04:43 <frosch123> tile_check: return 0; <- that disallows unconditionally :) 18:05:36 <frosch123> and uses the first string as error message, whichever that is 18:07:35 <FLHerne> Ok 18:07:42 <FLHerne> This seems like a bad example :P 18:07:57 <FLHerne> The first string is the class name, which is why it's that 18:08:02 * FLHerne fixes 18:08:14 <FLHerne> Unless you want to 18:11:26 <frosch123> please do, i never looked at the example :) 18:11:54 <andythenorth_> another day I am happy to help with examples 18:12:03 <andythenorth_> today I really need a day off from 'making mistakes with code' 18:12:10 <andythenorth_> which I have been doing for like 4 months no break 18:12:40 <andythenorth_> my hypothesis: if we have good examples, we can then ask for PRs to include examples 18:12:48 <andythenorth_> which will stop people asking me to write them 18:13:25 <andythenorth_> actually I'm exaggerating the 2nd point, but still I think PRs should come with an example so reviewer can validate 18:14:35 <frosch123> andythenorth_: the other day someone uploaded a industry newgrf to bananas, and credited manual industries as source, despite adding dozen of cargos. maybe some day people will fork the nml example for their stuff :p 18:15:28 <andythenorth_> :) 18:15:56 <andythenorth_> reddit wants a daylength newgrf 18:19:32 <frosch123> reddit got excited that there is more than one firs 18:19:54 <frosch123> it was not quite clear, whether they were refering to firs 1/2/3, or to economies 18:20:45 <frosch123> hmm, we are at firs4 now? 18:20:51 <frosch123> or 5 already? 18:21:04 <andythenorth_> both 18:26:03 *** snail_UES_ has quit IRC 18:27:45 <_dp_> oh waw, openttd now opens saves even when missing newgrfs? 18:27:55 <_dp_> how's that not breaking everything? 18:28:23 <andythenorth_> it falls back to stuff 18:28:33 <andythenorth_> it's kind of essential for newgrf dev btw 18:28:58 <frosch123> _dp_: you probably enabled newgrf dev settings 18:29:11 <frosch123> or one of the other hidden magic ones 18:29:15 <_dp_> oh, yeah, that's why 18:29:30 <FLHerne> https://github.com/OpenTTD/nml/pull/130 18:29:41 <FLHerne> (did DorpsGek go away?) 18:30:10 <Samu> @seen DorpsGek 18:30:10 <DorpsGek> Samu: I have not seen DorpsGek. 18:30:39 <FLHerne> DorpsGek: Get yourself a mirror, you silly bot 18:30:39 <DorpsGek> FLHerne: Error: 'yourself' is not a valid topic number. 18:31:22 <DorpsGek> hello 18:31:31 <frosch123> oh, wrong dorpsgek 18:32:56 <frosch123> FLHerne: enable whitespace in your editor 18:33:38 <DorpsGek_III> [OpenTTD/nml] frosch123 commented on pull request #130: Fix: Enable the example object to be placed in-game https://git.io/JfcNe 18:33:39 <FLHerne> Oh, tabs 18:34:10 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #130: Fix: Enable the example object to be placed in-game https://git.io/JfcbS 18:34:13 <frosch123> well, looks like the whole file is inconsistent :) 18:34:33 <FLHerne> So it is 18:34:39 <FLHerne> Anyway, fixed my bit 18:34:42 <DorpsGek_III> [OpenTTD/nml] frosch123 approved pull request #130: Fix: Enable the example object to be placed in-game https://git.io/JfcNU 18:35:39 *** Exec has quit IRC 18:36:13 *** Exec has joined #openttd 18:37:13 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #130: Fix: Enable the example object to be placed in-game https://git.io/JfcbS 18:41:56 <andythenorth_> thanks FLHerne 18:46:00 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #125: Codechange: Build examples in regression testing https://git.io/JfcXX 18:46:14 <FLHerne> ^ the tests should actually pass now, thanks glx! 18:47:16 <FLHerne> nmlc doesn't have a "fail on warning" flag, does it? 18:47:43 <FLHerne> They probably *shouldn't* actually pass, because the industry example is still broken 18:48:36 <frosch123> it has the opposite :) -q suppresses warnings 18:49:29 *** snail_UES_ has joined #openttd 18:49:29 <FLHerne> Why did anyone think that was a good idea? 18:49:43 <FLHerne> Huh, the tests failed, why? 18:50:36 <FLHerne> Oops, didn't rebase properly after the last commit 18:53:46 <Samu> 1.8.0 was the only 1.8 version right? 18:53:53 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #125: Codechange: Build examples in regression testing https://git.io/JfcXX 18:57:02 <FLHerne> Yay, the example tests pass! 18:57:05 <andythenorth_> x:) 18:57:09 <andythenorth_> oops 18:57:10 <andythenorth_> :) 18:57:20 *** snail_UES_ is now known as Guest24516 18:57:21 *** snail_UES_ has joined #openttd 19:00:38 *** Guest24516 has quit IRC 19:03:08 <TrueBrain> FLHerne: I guess that makes it beer-time! 19:09:06 <DorpsGek_III> [OpenTTD/nml] FLHerne approved pull request #129: Fix: TownNames debug_print https://git.io/JfcAF 19:09:48 <DorpsGek_III> [OpenTTD/nml] glx22 merged pull request #129: Fix: TownNames debug_print https://git.io/Jfcdq 19:10:31 <FLHerne> We should have a town_names example 19:11:08 <frosch123> use an existing grf then 19:11:16 <rudolfs[m]> I used Lithuanian repo as a template 19:11:18 <frosch123> with an grfid that is already used on bananas 19:11:35 <rudolfs[m]> Speaking of which, how do I get my town names into bananas? 19:11:43 <frosch123> townname people tend to copy stuff without understanding it, and then do not set their own grfid 19:12:00 <frosch123> rudolfs[m]: you go to bananas.openttd.org 19:12:07 <frosch123> everything else is written there 19:12:16 <glx> you can probably use the test grf from https://github.com/OpenTTD/nml/issues/116 19:12:35 <FLHerne> I was thinking that 19:13:15 <FLHerne> Unrelated, it seems daft that everyone sets `if (version_openttd(1,2,0,22723) > openttd_version) {`, ... or so 19:13:26 <FLHerne> It's usually wrong or outdated anyway 19:13:33 *** Wormnest has quit IRC 19:14:03 <FLHerne> For all but very complex grfs, nmlc should know better 19:14:06 <frosch123> i recommend against any version checks, unless nml learns to add them itself 19:14:15 <FLHerne> (it doesn't, of course) 19:14:49 <frosch123> i also think checking revisions is too detailed. people should just check releases 19:15:55 <glx> checking revision was useful for test version during feature implementation in openttd 19:16:30 <glx> but since the move to github... 19:18:47 <frosch123> when you write the grf, you do not know when all bugs in ottd are fixed :) 19:18:54 <frosch123> so a revision is pretty useless 19:19:08 <frosch123> nightly players use nightly 19:19:28 <frosch123> pp players use pp 19:21:24 <glx> I guess the advanced example at the bottom of https://newgrf-specs.tt-wiki.net/wiki/NML:Spritelayout was written before layout parameters 19:23:44 *** Wormnest has joined #openttd 19:40:45 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh opened pull request #8125: Fix: Two issues in MIDI file writer https://git.io/JfcpO 19:51:51 <Samu> how would you name the 3 variables pertaining to a dock? 19:51:58 <Samu> https://i.imgur.com/oD6Juf0.png 19:53:47 <Samu> dock_end, dock_pier, dock_water, so many ideas, all of them not clear enough of their own 19:58:44 *** Wormnest has quit IRC 19:58:44 *** iSoSyS has quit IRC 19:58:44 *** heffer has quit IRC 19:58:44 *** Laedek_ has quit IRC 19:58:44 *** osvaldo[m] has quit IRC 19:58:44 *** ookfof[m] has quit IRC 19:58:44 *** nolep[m] has quit IRC 19:58:44 *** jinks has quit IRC 19:58:44 *** nnyby has quit IRC 19:58:44 *** Vadtec has quit IRC 19:58:44 *** super_spooky has quit IRC 19:58:44 *** dwfreed has quit IRC 20:01:35 *** iSoSyS has joined #openttd 20:01:35 *** heffer has joined #openttd 20:01:35 *** Laedek_ has joined #openttd 20:01:35 *** osvaldo[m] has joined #openttd 20:01:35 *** ookfof[m] has joined #openttd 20:01:35 *** nolep[m] has joined #openttd 20:01:35 *** jinks has joined #openttd 20:01:35 *** dwfreed has joined #openttd 20:01:35 *** Vadtec has joined #openttd 20:01:35 *** super_spooky has joined #openttd 20:02:43 *** dwfreed has quit IRC 20:06:39 <Samu> just got some ideas based from the sprites: docking_tile, dock_slope_tile, dock_flat_tile 20:10:26 *** nnyby has joined #openttd 20:12:05 *** dwfreed has joined #openttd 20:22:05 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #131: Add: [Actions] Include pypy3 in test matrix https://git.io/JfcjU 20:22:12 *** iSoSyS has quit IRC 20:24:50 <FLHerne> Hm 20:35:52 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8125: Fix: Two issues in MIDI file writer https://git.io/JfcjS 20:43:47 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #8125: Fix: Two issues in MIDI file writer https://git.io/JfcpO 20:48:18 *** nnyby has quit IRC 20:49:09 *** dwfreed has quit IRC 20:54:15 *** dwfreed has joined #openttd 20:58:17 *** nnyby has joined #openttd 21:00:28 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #131: Add: [Actions] Include pypy3 in test matrix https://git.io/JfcjU 21:06:13 *** Wormnest has joined #openttd 21:07:28 *** Progman_ has joined #openttd 21:07:29 *** Progman has quit IRC 21:15:23 *** Samu has quit IRC 21:17:41 <glx> FLHerne: for windows it should be easy to get zlib headers with vcpkg 21:19:42 <glx> should work for OSX too 21:21:45 <FLHerne> glx: I guess so, it's a question of how much we care 21:22:00 <FLHerne> We already test cross-platform with CPython 21:24:16 <FLHerne> So is it really worth downloading and compiling a bunch of stuff several times for every PR, for the sake of the 0.0whatever% of bugs that happen to affect only PyPy and only on certain platforms? 21:24:55 <FLHerne> (and actually get detected by our test suite at all...) 21:25:07 <andythenorth_> oof 21:25:38 <FLHerne> I'd expect platform-related bugs to be about paths, weird encodings, whatever 21:25:44 <FLHerne> And we basically don't test those 21:26:10 <glx> oh for sure there are issues with encoding :) 21:27:10 <glx> on my machine with "pip install -e ." I can run nmlc, with "pip install ." I can't :) 21:27:50 <glx> but it's probably an issue with setuptools 21:29:21 <glx> oh and of course I can't run nmlc with "pip install nml" 21:32:28 <glx> for some reason "-e" uses "setup.py develop" I think, which uses easy install and generate a script with "#!<path>/python.exe -x" while standard install generates "#!<path>/python.exe" and fails to run because I have a ï in <path> 21:38:17 *** Wolf01 has quit IRC 21:39:41 *** Tirili has joined #openttd 21:42:31 *** nielsm has quit IRC 22:02:21 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfCJN 22:23:27 *** sla_ro|master has quit IRC 22:25:42 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfZi5 22:26:18 *** andythenorth_ has quit IRC 22:26:30 <glx> and I can merge 2 commits I think 22:31:27 <FLHerne> glx: That mess with the BinOps reminds me why I wrote #70 :P 22:31:42 <glx> hehe 22:31:46 *** nielsm has joined #openttd 22:32:02 <FLHerne> I guess the megachange should wait until after 0.5.1 22:32:18 <FLHerne> (no stable branches?) 22:33:08 <glx> I think stable branch is created when master is not compatible with previous version 22:33:42 <frosch123> it was only done once for 0.2 22:33:59 <frosch123> but essentially releases are only for distros 22:34:15 <frosch123> newgrf are either fine with ancient versions, or they need the latest greatest 22:34:43 <frosch123> do we have nightly builds? 22:35:15 <FLHerne> It might be worth having a fixes-only 0.5.2 whenever more NRT/industry bugs show up 22:35:28 <glx> no, but we could, pyinstaller should work for all os I think 22:36:26 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfZi5 22:38:51 <FLHerne> glx: In the first commit message, should mention it adds the shift? 22:38:57 <FLHerne> Doesn't just simplify 22:39:02 *** frosch123 has quit IRC 22:40:02 <glx> the shift was there for the constant version, and missing for the BinOp, now they are merged 22:46:31 <FLHerne> glx: I know, I mean that just "simplify Action2LayoutSprite.get_sprite_number" implies no behaviour change to me 22:47:29 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #118: Fix: Allow calculation for palette in spritelayout https://git.io/JfZi5 22:51:21 <FLHerne> ? 22:52:02 <glx> I add the "fix" in the message 22:52:13 <glx> *added 22:52:32 <FLHerne> Oh, I see it 22:52:36 <FLHerne> Thanks :-) 22:58:43 *** matt21347 has quit IRC 23:05:15 <FLHerne> I don't think I understand this well enough to be sure it works... 23:19:30 *** gelignite has quit IRC 23:23:11 *** Tirili has quit IRC 23:26:09 *** spnda has joined #openttd 23:26:21 <spnda> Are numbers allowed in string literals in NML? 23:28:19 <glx> https://newgrf-specs.tt-wiki.net/wiki/NML:Elementary_values 23:28:44 <FLHerne> spnda: Yes 23:29:29 <spnda> Ok thanks. Someone I know has had the assertion in string_literal.py, line 37 trigger for some reason recently. 23:29:37 <FLHerne> spnda: In fact, they're required if you want to reference things like the standard "3RDR" label for 3rd-rail railtypes 23:30:06 <spnda> So it might have been numbers. But what is that assertion for? To see if the value of the string equals the length of the string? 23:31:04 <spnda> https://github.com/OpenTTD/nml/blob/master/nml/expression/string_literal.py#L37 23:32:01 <FLHerne> spnda: String literals are, in most cases, written directly as bytes into the NFO/grf 23:32:02 <glx> use -s flag for more context 23:32:29 <FLHerne> i.e. a 4-character string is four bytes of output 23:32:47 * FLHerne wonders if that assert is correct for unicode chars 23:33:24 <FLHerne> No, but force_ascii is true so there can't be any :P 23:33:56 <glx> unicode is only allowed in strings 23:36:32 <FLHerne> glx: print_string() handles unicode unless the caller specifically sets force_ascii=False? 23:36:56 <FLHerne> It's used for town names and things 23:37:09 <spnda> glx: This is with -s: https://pastebin.com/WZGFuXzJ 23:38:01 <glx> what's the roadtype ? 23:38:19 <spnda> roadtype being the label? 23:38:25 <glx> yes 23:39:26 <FLHerne> spnda: Easiest if you just post the nml source somewhere 23:39:30 <FLHerne> Unless it's secret :P 23:39:41 <glx> yes that too :) 23:39:58 <glx> but at least in asserts when writing a roadtype label 23:44:04 <spnda> The 4 files with the roadtype definitions: https://drive.google.com/open?id=1s0NgOgfm3ss-cIYgIuj8WesdzLkcFHmr 23:44:25 <FLHerne> Oh, I think I know what's wrong 23:46:20 *** Progman_ has quit IRC 23:48:44 <glx> spnda: "WARD2" 23:48:47 <glx> too long 23:49:14 <glx> in 3_1865_pbbn.pnml 23:49:48 <spnda> Ah yes, found it, thanks a lot 23:49:52 <glx> but I think that should be checked earlier 23:50:23 <glx> assert should be a last resort failure :) 23:56:05 <spnda> It does, but the checking might have some issue about it being a multi line definition 23:57:13 <glx> I don't see where it's checked 23:58:28 <spnda> glx: Look at parameter.py, line 89. On line 100 it throws an error if the string length is not 4.