Times are UTC Toggle Colours
02:51:10 *** ChubbyPitbull has joined #openttd.dev 02:51:41 *** ChubbyPitbull has left #openttd.dev 02:52:53 *** ChubbyPitbull has joined #openttd.dev 02:54:38 *** ChubbyPitbull has joined #openttd.dev 04:54:37 *** TWC has joined #openttd.dev 05:03:57 *** frodus has joined #openttd.dev 05:04:54 *** TWC has quit IRC 06:01:46 *** ChanServ sets mode: +v ChubbyPitbull 06:57:51 *** Ristovski has joined #openttd.dev 07:10:40 *** ntoskrnl has joined #openttd.dev 07:29:49 *** LordAro has joined #openttd.dev 07:29:49 *** ChanServ sets mode: +v LordAro 07:38:26 *** Alberth has joined #openttd.dev 07:38:27 *** ChanServ sets mode: +v Alberth 09:08:45 *** frodus has quit IRC 09:54:36 *** ntoskrnl has quit IRC 10:22:53 *** frosch123 has joined #openttd.dev 10:22:53 *** ChanServ sets mode: +v frosch123 11:12:12 *** frodus has joined #openttd.dev 11:31:46 *** Supercheese has quit IRC 11:32:15 *** Supercheese has joined #openttd.dev 11:33:48 *** frodus has quit IRC 11:48:53 *** ntoskrnl has joined #openttd.dev 12:04:42 <ChubbyPitbull> Good Morning! 12:50:57 <frosch123> what should we set as the intentional behaviour of NWidgetMatrix pip_pre and pip_post wrt. RTL? 12:51:25 <frosch123> for horizontal containers there are NWidgetHorizontal and NWidgetHorizontalLTR 12:51:46 <frosch123> the former puts pre at the reading-begin, the latter always at the left 12:52:36 <frosch123> the existing NWidgetMatrix in ottd have symmetric pre=post, so it does not really matter 12:52:54 <frosch123> it just needs a definition :) 12:54:47 <Alberth> oh, it's the image matrix thingie 12:55:03 <frosch123> i kind of tend to make it consistent with NWidgetHorizontal, since NWidgetHorizontalLTR is a special case only used for the OSK window 12:55:22 <Alberth> that would also be my idea 12:55:47 <Alberth> if you want fixed direction, you'd add a RTL or LTR suffix, imho 12:55:55 <frosch123> though the matrix is a special thing anyway, since it applies the same pip to both horizontal and spacing 12:56:47 <Alberth> so perhaps its name is sub-optimal? 12:57:23 <Alberth> (although renaming at this time would seem a bit overkill to me) 12:58:05 <frosch123> i mean to write "both horizontal and vertical spacing" 12:58:27 <frosch123> one could also add an assertion(pre == post) :p 12:59:06 <frosch123> i don't see a usecase for asymmetric padding due to the shared horizontal/vertical spacing 13:00:09 <Alberth> a matrix widget to me would be a container to place a grid of child widgets 13:00:20 <Alberth> this thing just does images iirc 13:00:55 <frosch123> it does a grid of child widgets, with the restriction that all child widgets must be the same 13:01:51 <Alberth> ah, it's more general than I think it is thus. Good. 13:02:08 <frosch123> well, the child widget cannot have a complex state, since there is only once instance of it 13:02:23 <frosch123> so, it may only change depending on Window functions 13:02:34 <frosch123> like Draw or GetStringParam etc 13:02:39 <Alberth> and what is the problem exactly? 13:04:29 <frosch123> the problem is that fs#5686 tries to fix some misalignment in the matrix. but the usage of the pip stuff in the matrix is inconsistent (and did not matter in trunk due to being symmetrix), but the fs patches make it even more wrong, and extend the wrongness to other widgets 13:04:52 <frosch123> so, i need a specification how it should be :p 13:07:30 <frosch123> well, let's make it like NWidgetHorizontal 13:07:49 <frosch123> if we ever want asymmetric padding, that is need anyway 13:09:17 <Alberth> those padding problems should be solved outside the leaf widgets I think 13:09:53 <frosch123> hmm? it's always handled by the container 13:11:02 <Alberth> ok 13:40:44 <frosch123> http://paste.openttdcoop.org/show/2522/ <- seems to do it (basically fs#5686) 13:44:04 <frosch123> i guess completely unreadable .p 13:45:58 <Alberth> quite :) 13:46:12 <Alberth> new line 1594 seems unneeded 13:46:39 <Alberth> new line 1593 - widget_col * this->widget_w can be taken out of the ?: 13:46:52 <frosch123> yeah 13:48:04 <frosch123> oh, due to testing only rtl, i broke ltr :p 13:49:10 <Alberth> :) 13:50:31 <LordAro> who cares about that? :p 13:51:01 <Alberth> I don't entirely understand it, but I don't see anything unexpected 14:15:28 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25726 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:47:46 <ChubbyPitbull> Submitted my first patch, I feel so productive. Figuring this feeling will last right up to the point Zuu reviews it. 14:58:39 <Alberth> looks quite good 14:59:57 <LordAro> ChubbyPitbull: yup, that's generally how it works :) 15:03:22 <ChubbyPitbull> lol 15:03:23 <ChubbyPitbull> thanks! 15:07:07 <LordAro> ChubbyPitbull: for example, here's my first (incomplete, iirc) patch: http://paste.openttdcoop.org/show/376/ 15:07:15 <LordAro> and here's the review: http://paste.openttdcoop.org/show/378/ 15:07:28 <LordAro> with my responses, it seems 15:08:23 <LordAro> compliments to sir Alberth :) 15:09:20 <Alberth> surprised to see it's still available at the paste service :) 15:11:40 <LordAro> i went back into my pm history to find it :) 15:11:47 <ChubbyPitbull> lol 15:12:08 <ChubbyPitbull> haha "a bit picky are we", nice response 15:12:13 <LordAro> :p 15:32:46 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25727 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:34:01 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25728 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:41:08 <Alberth> ChubbyPitbull: http://paste.openttdcoop.org/show/2524/ rough first review, mostly code style, I don't know enough of the functions there 15:49:29 <ChubbyPitbull> Roger that 15:51:12 <ChubbyPitbull> Thanks for the feedback! Will make the corrections in a bit. 16:04:56 <ChubbyPitbull> Some of your comments reference code or in-souce comments I didn't change, I'll try to address them. 16:18:59 <LordAro> told you he was picky about documentation :P 16:19:14 <ChubbyPitbull> lol 16:30:47 <ChubbyPitbull> Alberth, added new patch addressing your comments http://bugs.openttd.org/task/5208 17:04:14 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25729 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:45:19 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25730 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:15:14 *** ntoskrnl has quit IRC 18:17:36 *** Alberth has left #openttd.dev 19:30:27 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25731 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:06:01 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25732 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 22:07:41 *** LordAro has quit IRC 22:19:39 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25733 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 22:56:43 *** frosch123 has quit IRC 23:31:27 *** Ristovski has quit IRC